Skip to content

Migrate tests #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Migrate tests #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103463d
Migrate tests
gem-neo4j Nov 6, 2025
83ce2d7
PR updates
gem-neo4j Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 25 additions & 26 deletions core/src/test/java/apoc/lock/LockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,43 +18,44 @@
*/
package apoc.lock;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
import static apoc.util.TestUtil.testCall;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;

import apoc.util.TestUtil;
import apoc.util.collection.Iterators;
import com.neo4j.test.extension.EnterpriseDbmsExtension;
import java.time.Duration;
import java.time.Instant;
import java.util.Collections;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.ClassRule;
import org.junit.Test;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.neo4j.configuration.GraphDatabaseSettings;
import org.neo4j.graphdb.GraphDatabaseService;
import org.neo4j.graphdb.Node;
import org.neo4j.graphdb.Transaction;
import org.neo4j.kernel.impl.locking.LockAcquisitionTimeoutException;
import org.neo4j.test.rule.DbmsRule;
import org.neo4j.test.rule.ImpermanentDbmsRule;
import org.neo4j.graphdb.TransactionFailureException;
import org.neo4j.test.TestDatabaseManagementServiceBuilder;
import org.neo4j.test.extension.ExtensionCallback;
import org.neo4j.test.extension.Inject;

@EnterpriseDbmsExtension(configurationCallback = "configure", createDatabasePerTest = false)
public class LockTest {

@ClassRule
public static DbmsRule db = new ImpermanentDbmsRule()
.withSetting(GraphDatabaseSettings.lock_acquisition_timeout, Duration.ofSeconds(1));
@Inject
GraphDatabaseService db;

@BeforeClass
public static void setUp() {
TestUtil.registerProcedure(db, Lock.class);
@ExtensionCallback
void configure(TestDatabaseManagementServiceBuilder builder) {
builder.setConfig(GraphDatabaseSettings.lock_acquisition_timeout, Duration.ofSeconds(1));
}

@AfterClass
public static void teardown() {
db.shutdown();
@BeforeAll
void setUp() {
TestUtil.registerProcedure(db, Lock.class);
}

@Test
public void shouldReadLockBlockAWrite() throws Exception {
void shouldReadLockBlockAWrite() throws Exception {

Node node;
try (Transaction tx = db.beginTx()) {
Expand All @@ -69,12 +70,10 @@ public void shouldReadLockBlockAWrite() throws Exception {

final Thread thread = new Thread(() -> {
System.out.println(Instant.now().toString() + " pre-delete");
try {
db.executeTransactionally(
"match (n) delete n", Collections.emptyMap(), result -> result.resultAsString());
fail("expecting lock timeout");
} catch (LockAcquisitionTimeoutException e) {
}

// TransactionFailure due to lock timeout
assertThrows(TransactionFailureException.class, () -> testCall(db, "MATCH (n) DELETE n", row -> {}));

System.out.println(Instant.now().toString() + " delete");
});
thread.start();
Expand Down
Loading