Migrate tests #863
Open
Migrate tests #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
requested changes
Nov 12, 2025
Contributor
Lojjs
left a comment
Lojjs
left a comment
There was a problem hiding this comment.
Good work! A few minor things and questions and one optional task if you are really bored
| MATCH (d)-[l:FLIGHTS_TO]->(p) return r as rel1,h as rel2"""; | ||
|
|
||
| @Before | ||
| public void setUp() { |
Contributor
There was a problem hiding this comment.
Optional: If you have enough energy, you could also remove public from all test classes and tests. Intellij are flagging it as warnings in junit 6
Contributor
Author
There was a problem hiding this comment.
Huh according to google you are correct, weird my intellij doesn't warn on it, maybe I am missing a setting somewhere!
| * @author inserpio | ||
| * @since 25.8.2016 | ||
| */ | ||
| @EnterpriseDbmsExtension() |
Contributor
There was a problem hiding this comment.
This one should be able to have createDatabasePerTest = false as well as we are not creating any data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate more tests from Junit 4