Skip to content

chore: update dependencies #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahal merged 1 commit into from
Jun 18, 2025
Merged

chore: update dependencies #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,16 @@ async def test_async_client_rest(aioresponses, async_client):

aioresponses.delete(url, status=200)
await client.delete("/octocat")
aioresponses.assert_called_with(url, "DELETE", data="null")
aioresponses.assert_called_with(
url,
"DELETE",
headers={
"Accept": "application/vnd.github+json",
"Authorization": "Bearer abc",
},
Copy link
Contributor Author

@ahal ahal Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's going on here. At first I was able to reproduce this locally, and then I did something and now I can't anymore, but it still reproduces in CI?

I guess I could edit the test to be less strict about what it asserts, but I'm worried this might be uncovering an actual issue :/

Copy link
Contributor

@jcristau jcristau Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding something in the commit message about this test change?

Copy link
Contributor Author

@ahal ahal Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

Turns out that locally I had somehow managed to re-install the old dependency set. So it's at least consistent. I guess it's a change to aiohttp.

data="null",
allow_redirects=True,
)

aioresponses.get(url, status=401)
with pytest.raises(ClientResponseError):
Expand Down
Loading
Loading