chore: update dependencies #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
ahal/push-xmmvrouvmmls
branch
2 times, most recently
from
e64a862 to
ee08b8c
Compare
ahal
commented
Jun 13, 2025
| headers={ | ||
| "Accept": "application/vnd.github+json", | ||
| "Authorization": "Bearer abc", | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
I'm not sure what's going on here. At first I was able to reproduce this locally, and then I did something and now I can't anymore, but it still reproduces in CI?
I guess I could edit the test to be less strict about what it asserts, but I'm worried this might be uncovering an actual issue :/
Contributor
There was a problem hiding this comment.
Do you mind adding something in the commit message about this test change?
Contributor
Author
There was a problem hiding this comment.
Will do.
Turns out that locally I had somehow managed to re-install the old dependency set. So it's at least consistent. I guess it's a change to aiohttp.
The test change is needed to fix a failure that started happening with this dependency bump. I didn't track the change down, but likely involves the aiohttp update.
ahal
force-pushed
the
ahal/push-xmmvrouvmmls
branch
from
ee08b8c to
b41168e
Compare
jcristau
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.