Skip to content

feat: match legacy toString output for NumberDecimal type #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

feat: match legacy toString output for NumberDecimal type #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae7c47e
feat: match legacy toString output for NumberDecimal type
tcannon91 Oct 14, 2025
3618141
Use new toString for toJson
tcannon91 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion snippets/mongocompat/mongotypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,9 +443,14 @@ if (typeof NumberDecimal !== 'undefined') {
if (!NumberDecimal.prototype) {
NumberDecimal.prototype = {};
}
NumberDecimal.prototype.nativeToString = NumberDecimal.prototype.toString

NumberDecimal.prototype.tojson = function() {
return this.toString();
return this.nativeToString();
};

NumberDecimal.prototype.toString = function() {
return `NumberDecimal("${this.nativeToString()}")`;
};
}

Expand Down
3 changes: 3 additions & 0 deletions snippets/mongocompat/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@ assert.strictEqual(minLong.bottom, 0);
assert.strictEqual(minLong.exactValueString, "-9223372036854775808");
const nl2 = NumberLong("200");
assert.strictEqual(maxLong.compare(nl2), 1);
const decimal = NumberDecimal("1.1");
assert.strictEqual(decimal.toString(), 'NumberDecimal("1.1")');
assert.strictEqual(decimal.tojson(), '1.1');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

root@bce3f00f5209:/# mongo --nodb
MongoDB shell version v5.0.31
================
Warning: the "mongo" shell has been superseded by "mongosh",
which delivers improved usability and compatibility.The "mongo" shell has been deprecated and will be removed in
an upcoming release.
For installation instructions, see
https://docs.mongodb.com/mongodb-shell/install/
================
> NumberDecimal('1.1').tojson()
NumberDecimal("1.1")

seems to disagree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, sorry I was focused on maintaining the previous output, not compatibility. Will update