feat: match legacy toString output for NumberDecimal type #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Oct 15, 2025
snippets/mongocompat/test.js
Outdated
| assert.strictEqual(maxLong.compare(nl2), 1); | ||
| const decimal = NumberDecimal("1.1"); | ||
| assert.strictEqual(decimal.toString(), 'NumberDecimal("1.1")'); | ||
| assert.strictEqual(decimal.tojson(), '1.1'); |
There was a problem hiding this comment.
root@bce3f00f5209:/# mongo --nodb
MongoDB shell version v5.0.31
================
Warning: the "mongo" shell has been superseded by "mongosh",
which delivers improved usability and compatibility.The "mongo" shell has been deprecated and will be removed in
an upcoming release.
For installation instructions, see
https://docs.mongodb.com/mongodb-shell/install/
================
> NumberDecimal('1.1').tojson()
NumberDecimal("1.1")
seems to disagree?
There was a problem hiding this comment.
You are correct, sorry I was focused on maintaining the previous output, not compatibility. Will update
addaleax
approved these changes
Oct 15, 2025
|
published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match output with legacy mongo shell for toString method
Jira ticket: https://jira.mongodb.org/browse/STREAMS-1983