Skip to content

STREAMS-1895: Add old shell compatibility of NumberLong for JS Engine #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
Merged

STREAMS-1895: Add old shell compatibility of NumberLong for JS Engine #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
022393f
STREAMS-1895: Add old shell compatibility of NumberLong for JS Engine
LijieZhang1998 Oct 10, 2025
41ffb3b
refactor by comments
LijieZhang1998 Oct 13, 2025
7b5ad94
remove debug
LijieZhang1998 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions snippets/mongocompat/mongotypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,53 @@ if (!NumberLong.prototype) {
NumberLong.prototype = {};
}

NumberLong.prototype.nativeToString = NumberLong.prototype.toString;
NumberLong.prototype.toString = function () {
return `NumberLong(${this.nativeToString()})`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't catch all cases correctly – if the number is larger than 2**31-1 in magnitude, then the legacy server added quotes around the value

(mongosh intentionally always adds quotes, and I'd consider going that route here too, even if it limits compatibility with the legacy server shell/$function)

};

NumberLong.prototype.tojson = function() {
return this.toString();
};

Object.defineProperty(NumberLong.prototype, 'floatApprox', {
enumerable: false,
configurable: true,
get: function() {
return Number(this.nativeToString());
}
});

Object.defineProperty(NumberLong.prototype, 'top', {
enumerable: false,
configurable: true,
get: function() {
const str = this.nativeToString();
const bigIntValue = BigInt(str);
const unsigned64 = bigIntValue < 0n
? bigIntValue + (1n << 64n)
: bigIntValue;
return Number((unsigned64 >> 32n) & 0xFFFFFFFFn);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const str = this.nativeToString();
const bigIntValue = BigInt(str);
const unsigned64 = bigIntValue < 0n
? bigIntValue + (1n << 64n)
: bigIntValue;
return Number((unsigned64 >> 32n) & 0xFFFFFFFFn);
return this.high;

}
});

Object.defineProperty(NumberLong.prototype, 'bottom', {
enumerable: false,
configurable: true,
get: function() {
const str = this.nativeToString();
const bigIntValue = BigInt(str);
const unsigned64 = bigIntValue < 0n
? bigIntValue + (1n << 64n)
: bigIntValue;
return Number(unsigned64 & 0xFFFFFFFFn);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const str = this.nativeToString();
const bigIntValue = BigInt(str);
const unsigned64 = bigIntValue < 0n
? bigIntValue + (1n << 64n)
: bigIntValue;
return Number(unsigned64 & 0xFFFFFFFFn);
return this.low;

(you'll want to also verify that these have the correct signedness for negative values)

}
});

NumberLong.prototype.exactValueString = function() {
return this.nativeToString();
};

// NumberInt
if (!NumberInt.prototype) {
NumberInt.prototype = {};
Expand Down
10 changes: 10 additions & 0 deletions snippets/mongocompat/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,14 @@
load(__dirname + '/index.js');

assert.strictEqual(ObjectId('0123456789abcdef01234567').tojson(), 'ObjectId("0123456789abcdef01234567")');

assert.strictEqual(BinData(4, 'abcdefgh').toString(), 'BinData(4,"abcdefgh")');

assert.strictEqual(NumberLong(1234567890).toString(), 'NumberLong(1234567890)');
const nl1 = NumberLong(9.223372036854776e+18, 2147483647, 4294967295);
assert.strictEqual(nl1.floatApprox, 9223372036854776000);
assert.strictEqual(nl1.top, 2147483647);
assert.strictEqual(nl1.bottom, 4294967295);
assert.strictEqual(nl1.exactValueString(), "9223372036854775807");
const nl2 = NumberLong("200");
assert.strictEqual(nl1.compare(nl2), 1);