STREAMS-1895: Add old shell compatibility of NumberLong for JS Engine #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Oct 11, 2025
snippets/mongocompat/mongotypes.js
Outdated
|
|
||
| NumberLong.prototype.nativeToString = NumberLong.prototype.toString; | ||
| NumberLong.prototype.toString = function () { | ||
| return `NumberLong(${this.nativeToString()})`; |
There was a problem hiding this comment.
That won't catch all cases correctly – if the number is larger than 2**31-1 in magnitude, then the legacy server added quotes around the value
(mongosh intentionally always adds quotes, and I'd consider going that route here too, even if it limits compatibility with the legacy server shell/$function)
snippets/mongocompat/mongotypes.js
Outdated
Comment on lines
402
to
407
| const str = this.nativeToString(); | ||
| const bigIntValue = BigInt(str); | ||
| const unsigned64 = bigIntValue < 0n | ||
| ? bigIntValue + (1n << 64n) | ||
| : bigIntValue; | ||
| return Number((unsigned64 >> 32n) & 0xFFFFFFFFn); |
There was a problem hiding this comment.
Suggested change
| const str = this.nativeToString(); | |
| const bigIntValue = BigInt(str); | |
| const unsigned64 = bigIntValue < 0n | |
| ? bigIntValue + (1n << 64n) | |
| : bigIntValue; | |
| return Number((unsigned64 >> 32n) & 0xFFFFFFFFn); | |
| return this.high; |
snippets/mongocompat/mongotypes.js
Outdated
Comment on lines
415
to
420
| const str = this.nativeToString(); | ||
| const bigIntValue = BigInt(str); | ||
| const unsigned64 = bigIntValue < 0n | ||
| ? bigIntValue + (1n << 64n) | ||
| : bigIntValue; | ||
| return Number(unsigned64 & 0xFFFFFFFFn); |
There was a problem hiding this comment.
Suggested change
| const str = this.nativeToString(); | |
| const bigIntValue = BigInt(str); | |
| const unsigned64 = bigIntValue < 0n | |
| ? bigIntValue + (1n << 64n) | |
| : bigIntValue; | |
| return Number(unsigned64 & 0xFFFFFFFFn); | |
| return this.low; |
(you'll want to also verify that these have the correct signedness for negative values)
addaleax
approved these changes
Oct 13, 2025
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.