Repository navigation
Fix achievement unlock and PC client disconnect crashes - #27
Merged
James Lenell (jameslen-atg) merged 1 commit intoNov 10, 2026
Merged
James Lenell (jameslen-atg) merged 1 commit into
James Lenell (jameslen-atg) merged 1 commit into
Conversation
Defer achievement continuations until native completion cleanup, pin the merged Party leave ownership fix, and hide Matchmaking and Leaderboards menu entries while retaining their backing implementations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
James Lenell (jameslen-atg)
requested review from
a team
and
a balanced review from Copilot
November 10, 2026 22:03
There was a problem hiding this comment.
🔵 Needs a closer look
The native Party teardown ownership fix lacks console disconnect and shutdown revalidation, leaving memory-safety-sensitive lifecycle behavior for a platform reviewer to validate.
No open issues 🎉
What changed in this PR
This PR improves crash handling around achievement reporting and PC disconnects, and simplifies the main menu while retaining the underlying matchmaking and leaderboard features.
Changes:
- Defer achievement continuations until native cleanup finishes and reject stale account-generation results.
- Remove Matchmaking and Leaderboards menu entries while preserving handlers, screens, and online score submission.
- Extend behavioral coverage and document deferred reporting, native disconnect protections, and menu availability.
| File | Description |
|---|---|
| tools/tests/pregame_flow_tests.gd | Verify hidden matchmaking entry and retained handler behavior. |
| tools/tests/platform_reporting_tests.gd | Cover deferred completions, reentrancy, and account invalidation. |
| tools/tests/leaderboard_tests.gd | Check remaining menu rows and retained leaderboard access guards. |
| scripts/ui/screens/main_menu_screen.gd | Remove Matchmaking and Leaderboards rows and related row tracking. |
| scripts/services/achievement_service.gd | Defer native results and guard stale cache access. |
| README.md | Describe the reduced menu and retained features. |
| docs/platform-services.md | Explain disconnect protections and deferred achievement reporting. |
| docs/multiplayer.md | Clarify that matchmaking remains implemented but hidden. |
| docs/matchmaking.md | Mark menu walkthroughs as requiring restoration of the entry. |
| docs/leaderboards.md | Clarify hidden menu access and continued score submission. |
Review effort: Balanced
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3639dfb050706517a6cbb272616a28db1bbc5f29from Fix Party client disconnect crash from overlapping leave operations XBOX-Godot-Sample#216. The addon shares overlapping peer-close and explicit network leaves and rejects stale completion contexts before dereferencing them, addressing the PC client cable-pull crash.Validation
Dependency and target
mainby user confirmation because this repository has nodevelopbranch.