Skip to content

Fix achievement unlock and PC client disconnect crashes - #27

Merged
James Lenell (jameslen-atg) merged 1 commit into
mainfrom
jameslen-microsoft-achievement-unlock-crash
Nov 10, 2026
Merged

James Lenell (jameslen-atg) merged 1 commit into
mainfrom
jameslen-microsoft-achievement-unlock-crash

Conversation

@jameslen-atg

Copy link
Copy Markdown
Member

Summary

  • Defer achievement query, update, and redundant-progress recheck continuations until native completion cleanup finishes, preventing reentrant request-list mutation during unlocks. Fence deferred cache access and subsequent reporting at account-generation boundaries.
  • Pin the addon to merged commit 3639dfb050706517a6cbb272616a28db1bbc5f29 from Fix Party client disconnect crash from overlapping leave operations XBOX-Godot-Sample#216. The addon shares overlapping peer-close and explicit network leaves and rejects stale completion contexts before dereferencing them, addressing the PC client cable-pull crash.
  • Remove Matchmaking and Leaderboards main-menu entries while retaining their handlers, screens, services, and online-match score submission. Update documentation and behavioral coverage.

Validation

  • Isolated game behavioral suite: 20,726 assertions passed.
  • Native Party failure and public API suites: 56 tests / 1,660 assertions passed. Native shutdown still logged ObjectDB/resource-in-use diagnostics.
  • Production Debug and Release addons rebuilt with test hooks disabled.
  • Updated PC release exported, registered, and launched; user reproduced client cable pull and confirmed no crash.
  • Console release containing the achievement and menu changes was installed. The native disconnect fix has not been revalidated on console.
  • Documentation framing and diff whitespace checks passed.

Dependency and target

Defer achievement continuations until native completion cleanup, pin the merged Party leave ownership fix, and hide Matchmaking and Leaderboards menu entries while retaining their backing implementations.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The native Party teardown ownership fix lacks console disconnect and shutdown revalidation, leaving memory-safety-sensitive lifecycle behavior for a platform reviewer to validate.

No open issues 🎉

What changed in this PR

This PR improves crash handling around achievement reporting and PC disconnects, and simplifies the main menu while retaining the underlying matchmaking and leaderboard features.

Changes:

  • Defer achievement continuations until native cleanup finishes and reject stale account-generation results.
  • Remove Matchmaking and Leaderboards menu entries while preserving handlers, screens, and online score submission.
  • Extend behavioral coverage and document deferred reporting, native disconnect protections, and menu availability.
File Description
tools/​tests/​pregame_flow_tests.gd Verify hidden matchmaking entry and retained handler behavior.
tools/​tests/​platform_reporting_tests.gd Cover deferred completions, reentrancy, and account invalidation.
tools/​tests/​leaderboard_tests.gd Check remaining menu rows and retained leaderboard access guards.
scripts/​ui/​screens/​main_menu_screen.gd Remove Matchmaking and Leaderboards rows and related row tracking.
scripts/​services/​achievement_service.gd Defer native results and guard stale cache access.
README.md Describe the reduced menu and retained features.
docs/​platform-services.md Explain disconnect protections and deferred achievement reporting.
docs/​multiplayer.md Clarify that matchmaking remains implemented but hidden.
docs/​matchmaking.md Mark menu walkthroughs as requiring restoration of the entry.
docs/​leaderboards.md Clarify hidden menu access and continued score submission.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants