Repository navigation
Fix fail-open voice communication privacy for XR015 - #28
Merged
James Lenell (jameslen-atg) merged 3 commits intoNov 11, 2026
Merged
James Lenell (jameslen-atg) merged 3 commits into
James Lenell (jameslen-atg) merged 3 commits into
Conversation
Defer achievement continuations until native completion cleanup, pin the merged Party leave ownership fix, and hide Matchmaking and Leaderboards menu entries while retaining their backing implementations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Close failed and pending voice privacy paths, revoke native audio permissions on policy invalidation and roster removal, and cover XR015 communication restrictions with behavioral regressions and updated guidance. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
James Lenell (jameslen-atg)
requested review from
a team
and
a balanced review from Copilot
November 10, 2026 22:37
There was a problem hiding this comment.
🟡 Changes recommended
A failed native permission revocation can leave an already-authorized voice control active, with no fail-closed fallback or retry after roster removal.
1 open issue
What changed in this PR
This PR hardens per-player voice privacy for XR015 by requiring affirmative authorization before granting Party audio permissions. Live console validation remains outstanding; automated coverage does not establish a certification pass.
Changes:
- Deny unresolved or invalid voice/text permission responses while preserving independent channel verdicts.
- Revoke peer permissions on policy invalidation and roster removal, and prevent local unmute from bypassing restrictions.
- Add behavioral coverage and a live Friends-only privacy walkthrough.
| File | Description |
|---|---|
tools/tests/voice_chat_tests.gd |
Adds privacy, revocation, roster, and privilege-resolution coverage. |
scripts/services/privacy_service.gd |
Defaults unknown verdicts to denial and validates permission answers. |
scripts/services/chat_service.gd |
Gates audio on peer authorization and revokes invalidated permissions. |
scripts/autoload/platform_session.gd |
Applies peer policy to roster and account lifecycle changes. |
docs/xr-compliance.md |
Updates privacy guarantees and certification caveats. |
docs/walkthroughs.md |
Adds Friends-only and third-device-host validation steps. |
docs/platform-services.md |
Documents fail-closed channel authorization and revocation behavior. |
Review effort: Balanced
| return | ||
| for entity_key: Dictionary in chat.get_remote_entity_keys(): | ||
| # Start every native permission update before awaiting any completion. | ||
| _apply_peer_permissions(entity_key) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Addresses fail-open voice privacy paths relevant to XR015-01 User Communication, where a Friends-only account could receive voice from a nonfriend.
Validation
Live validation still required
These runs use service doubles, not two live Xbox accounts. The exact reported Friends-only scenario, including both players joining a third device's host, still needs live console confirmation. This PR does not claim an XR015 certification pass.
No new PC or console packages have been exported or deployed for this change. Prior crash fixes from #27 are already on main and are excluded from this PR's file diff.