Skip to content

Fix fail-open voice communication privacy for XR015 - #28

Merged
James Lenell (jameslen-atg) merged 3 commits into
mainfrom
jameslen-microsoft-achievement-unlock-crash
Nov 11, 2026
Merged

James Lenell (jameslen-atg) merged 3 commits into
mainfrom
jameslen-microsoft-achievement-unlock-crash

Conversation

@jameslen-atg

Copy link
Copy Markdown
Member

Summary

Addresses fail-open voice privacy paths relevant to XR015-01 User Communication, where a Friends-only account could receive voice from a nonfriend.

  • Require affirmative per-player voice authorization before granting Party SendAudio/ReceiveAudio. New controls, missing XUIDs, unresolved relationships, and failed or malformed permission responses grant no audio.
  • Revoke native audio permissions on account/session policy invalidation and roster removal, including lingering chat controls. Local unmute cannot override pending or platform-denied relationships.
  • Preserve independent voice/text verdicts and the existing communications privilege check, resolution UI, and recheck flow.
  • Validate permission response identity/type, leave transient failures uncached, and add behavioral coverage and a two-console certification walkthrough.

Validation

  • Full isolated game behavioral suite on Godot 4.6.2: 20,772 assertions passed.
  • Multiplayer suite on the Godot 4.5.1 console fork: 1,096 assertions passed.
  • Documentation framing and diff whitespace checks passed.
  • Coverage exercises friends/nonfriends, failed/malformed/missing answers, retry, pending and late controls, local-unmute restrictions, native permission revocation before completion, roster mapping/removal, account teardown, and communications privilege UI resolution/recheck.

Live validation still required

These runs use service doubles, not two live Xbox accounts. The exact reported Friends-only scenario, including both players joining a third device's host, still needs live console confirmation. This PR does not claim an XR015 certification pass.

No new PC or console packages have been exported or deployed for this change. Prior crash fixes from #27 are already on main and are excluded from this PR's file diff.

James Lenell and others added 3 commits November 10, 2026 14:02
Defer achievement continuations until native completion cleanup, pin the merged Party leave ownership fix, and hide Matchmaking and Leaderboards menu entries while retaining their backing implementations.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Close failed and pending voice privacy paths, revoke native audio permissions on policy invalidation and roster removal, and cover XR015 communication restrictions with behavioral regressions and updated guidance.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A failed native permission revocation can leave an already-authorized voice control active, with no fail-closed fallback or retry after roster removal.

1 open issue
What changed in this PR

This PR hardens per-player voice privacy for XR015 by requiring affirmative authorization before granting Party audio permissions. Live console validation remains outstanding; automated coverage does not establish a certification pass.

Changes:

  • Deny unresolved or invalid voice/text permission responses while preserving independent channel verdicts.
  • Revoke peer permissions on policy invalidation and roster removal, and prevent local unmute from bypassing restrictions.
  • Add behavioral coverage and a live Friends-only privacy walkthrough.
File Description
tools/​tests/​voice_chat_tests.gd Adds privacy, revocation, roster, and privilege-resolution coverage.
scripts/​services/​privacy_service.gd Defaults unknown verdicts to denial and validates permission answers.
scripts/​services/​chat_service.gd Gates audio on peer authorization and revokes invalidated permissions.
scripts/​autoload/​platform_session.gd Applies peer policy to roster and account lifecycle changes.
docs/​xr-compliance.md Updates privacy guarantees and certification caveats.
docs/​walkthroughs.md Adds Friends-only and third-device-host validation steps.
docs/​platform-services.md Documents fail-closed channel authorization and revocation behavior.

Review effort: Balanced

return
for entity_key: Dictionary in chat.get_remote_entity_keys():
# Start every native permission update before awaiting any completion.
_apply_peer_permissions(entity_key)
@jameslen-atg
James Lenell (jameslen-atg) merged commit c52cff0 into main Nov 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants