Skip to content

fix(dfu): buffer 16 pending packets during lazy erase #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 2 commits into from
Oct 25, 2026
Merged

fix(dfu): buffer 16 pending packets during lazy erase #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
350bc72
fix(dfu): buffer 16 pending packets during lazy erase
jamesarich Oct 23, 2026
e29ea03
docs: state the pending-ring change as capacity
jamesarich Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ it and is upstream Adafruit history, kept for provenance.
- The DFU screen shows upload progress during UF2, serial, and BLE transfers, as a bar in place of the banner. The title reads BOOTLOADER during a bootloader update, ERASE during a factory erase, WRONG FILE for a UF2 this board cannot take, and NO FIRMWARE when DFU starts without a valid application.
- A DFU session started after a SoftDevice update no longer ends before it begins.
- Build change, no behavior change: the bootloader is now compiled with `-flto`, which shrinks every image by about 3.3 KB of flash. Section addresses and SoftDevice call sites are unchanged.
- The lazy-erase packet buffer holds 16 packets instead of 8. Costs about 2 KB of `.bss`.

## OTAFIX 2.5

Expand Down
2 changes: 1 addition & 1 deletion lib/sdk11/components/drivers_nrf/pstorage/pstorage_raw.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
#endif

#define PENDING_PACKET_SIZE 256 /**< Maximum size of a single pending packet data buffer. */
#define PENDING_PACKET_COUNT 8 /**< Maximum number of packets that can be buffered during lazy erase. */
#define PENDING_PACKET_COUNT 16 /**< Packets buffered during lazy erase; must exceed the largest client PRN interval (Android 10, Apple 8). */

uint8_t * dfu_page_erased; /**< Pointer to page erased status array, set by DFU layer. */
uint32_t dfu_image_page_count; /**< Number of pages in DFU image, set by DFU layer. */
Expand Down
Loading