Repository navigation
fix(dfu): buffer 16 pending packets during lazy erase - #76
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Buffer capacity and documentation lib/sdk11/components/drivers_nrf/pstorage/pstorage_raw.c, changelog.md |
PENDING_PACKET_COUNT changes from 8 to 16. Its comment describes the client PRN interval requirement and gives Android and Apple examples. The changelog records the new capacity and approximate .bss cost. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Feature
Suggested reviewers: oltaco, rcarteraz
Merge Risk: 
Minimal · up to 88903
-
The 16-packet buffer change is ready to merge with no identified correctness or operational risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the packet store,
Sixteen wait beside the door.
The erase moves at a gentle pace,
More packets find a holding place.
Two kilobytes join the .bss lore,
Then hops away to review once more.
Comment @coderabbitai help to get the list of available commands.
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performed
|
8890345 to
e29ea03
Compare
Checklist
tools/build_all.py(or CI's board matrix) passesDescription of Change
Android streams 244 B packets with PRN 10, so up to 2440 B can be in flight while a page erases, more than the 8-slot ring holds on paper. This doubles the ring, RAM only (about 2.2 KB of
.bss).Measured, the 8-slot ring copes today: the Meshtastic Android app (2.8.4) updated a Wio Tracker L1 3 of 3 times on master's 8-slot ring and 3 of 3 on this 16-slot ring, both at about 9.6 KB/s with no
NO_MEM, error notification or retry; a Linux client at 4.3 KB/s was clean on both as well. So this is headroom for a faster client or a slower erase, not a fix for an observed failure.Summary by CodeRabbit