Skip to content

Remove argument hashing from field aliases #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GrandLarseny wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove argument hashing from field aliases #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b056bfd
Use stable hashing for arguments
GrandLarseny Dec 11, 2024
0119a3c
Use hash value description for generating stable hash
GrandLarseny Dec 12, 2024
8630d08
Remove the argument hash from the field alias
GrandLarseny Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftGraphQL/Document/Argument.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public struct Argument: Hashable {

let value: AnyCodable?

/*
/**
NOTE:
We use an internal VariableEncoder structure that is
a chiseled version of Swift's JSONEncoder. The main difference
Expand Down Expand Up @@ -59,7 +59,7 @@ public struct Argument: Hashable {

// MARK: Hashable Value

/*
/**
We use hashable value struct to make sure that fields with same values
but different paths or names don't collide in the variables.

Expand Down
6 changes: 3 additions & 3 deletions Sources/SwiftGraphQL/Document/Field.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ public enum GraphQLField {
/// - Note: Fragments don't have alias.
public var alias: String? {
switch self {
case let .leaf(name, parent, arguments),
let .composite(name, parent, _, arguments, _):
return "\(name.camelCasePreservingSurroundingUnderscores)\(parent.camelCasePreservingSurroundingUnderscores)_\(arguments.hash)"
case let .leaf(name, parent, _),
let .composite(name, parent, _, _, _):
return "\(name.camelCasePreservingSurroundingUnderscores)\(parent.pascalCase)"
case .fragment:
return nil
}
Expand Down