Remove argument hashing from field aliases#209
Open
GrandLarseny wants to merge 3 commits intomaticzav:mainfrom
Open
Remove argument hashing from field aliases#209GrandLarseny wants to merge 3 commits intomaticzav:mainfrom
GrandLarseny wants to merge 3 commits intomaticzav:mainfrom
Conversation
GrandLarseny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift will use a randomizing hash function as part of the standard library. This is great for cryptographic purposes, but during my use of the swift-graphql library I have need to be able to mock data with local JSON files. Because the field keys are random with every query (due to using Swift's standard hashing function), I cannot mock data with static JSON file.
This pull request pulls out the randomized hash. I might be missing the original purpose of having a hashed value of the arguments, but I do not see any benefit to having the field name aliases include a random value in every query.