ot_earlgrey: add JTAG support to LC Ctrl
#274
Open
+99
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luismarques
force-pushed
the
lc_ctrl_jtag
branch
from
310b170 to
b408a44
Compare
AlexJones0
reviewed
Nov 1, 2025
luismarques
force-pushed
the
lc_ctrl_jtag
branch
from
b408a44 to
d0e0d84
Compare
AlexJones0
reviewed
Nov 3, 2025
luismarques
force-pushed
the
lc_ctrl_jtag
branch
2 times, most recently
from
62e6f92 to
33c4756
Compare
Signed-off-by: Luís Marques <[email protected]>
luismarques
force-pushed
the
lc_ctrl_jtag
branch
from
33c4756 to
30e97b3
Compare
2 tasks
rivos-eblot
requested changes
Nov 12, 2025
rivos-eblot
left a comment
rivos-eblot
left a comment
There was a problem hiding this comment.
LGTM, except the ABIS constant.
I think you need to update the documentation so that the LC / DMI interface is referenced for ot_earlgrey.md as it is for ot_darjeeling.md. You may also need to add a machine section to lc_ctrl_dmi.md in a similar manner done for example in of_flash.md:
## Machine specific options
### EarlGrey Machine
...
to document the new JTAG controller with an example for its chardev, see for example Remote bitbang protocol section in jtag-dm.md
| * words on the TL-UL side, addressing [0 .. 2^7*4) bytes, and accessing the LC | ||
| * Ctrl registers at the appropriate (documented) offset. | ||
| */ | ||
| #define OT_EG_LC_CTRL_TAP_DMI_ABIS 7u |
There was a problem hiding this comment.
Is ABIS an ABITS typo (Address BITS) or is it referring to something else? (not enough coffee yet for me)
Author
There was a problem hiding this comment.
oops, that was a typo. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.