-
Notifications
You must be signed in to change notification settings - Fork 55
Deprecate ingress nginx #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprecate ingress nginx #1486
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -217,7 +217,7 @@ Then open your browser and navigate to `http://localhost:8080`. Log in with user | |||||
|
|
||||||
| ### Option 2: Ingress | ||||||
|
|
||||||
| Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller: | ||||||
| Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller (deperecated): | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo in "deperecated" - should be "deprecated".
Suggested change
|
||||||
|
|
||||||
| ```yaml title="grafana-ingress.yaml" | ||||||
| apiVersion: networking.k8s.io/v1 | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -546,7 +546,7 @@ spec: | |||||
| annotations: | ||||||
| nginx.ingress.kubernetes.io/force-ssl-redirect: "true" | ||||||
| nginx.ingress.kubernetes.io/backend-protocol: "HTTP" | ||||||
| ingressClassName: "nginx" | ||||||
| ingressClassName: "nginx" # deperecated | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo in "deperecated" - should be "deprecated".
Suggested change
|
||||||
| hostname: {{ .Values.loft.virtualClusterName }}-{{ .Values.loft.project }}-{{ .Values.loft.clusterAnnotations.domainPrefix }}.{{ .Values.loft.clusterAnnotations.domain }} | ||||||
| tls: true | ||||||
| ingressGrpc: | ||||||
|
|
@@ -556,7 +556,7 @@ spec: | |||||
| logLevel: "debug" | ||||||
| ingress: | ||||||
| enabled: true | ||||||
| ingressClassName: "nginx" | ||||||
| ingressClassName: "nginx" # deperecated | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo in "deperecated" - should be "deprecated".
Suggested change
|
||||||
| annotations: | ||||||
| nginx.ingress.kubernetes.io/force-ssl-redirect: "true" | ||||||
| hostname: {{ .Values.loft.virtualClusterName }}-{{ .Values.loft.project }}-{{ .Values.loft.clusterAnnotations.domainPrefix }}-appset.{{ .Values.loft.clusterAnnotations.domain }} | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -278,7 +278,7 @@ spec: | |||||
| solvers: | ||||||
| - http01: | ||||||
| ingress: | ||||||
| ingressClassName: nginx | ||||||
| ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The deprecation comment appears twice in this line. Consider consolidating.
Suggested change
|
||||||
| - dns01: | ||||||
| cloudflare: | ||||||
| email: [email protected] | ||||||
|
|
@@ -414,7 +414,7 @@ kind: Ingress | |||||
| metadata: | ||||||
| name: secure-app-ingress | ||||||
| annotations: | ||||||
| kubernetes.io/ingress.class: nginx | ||||||
| kubernetes.io/ingress.class: nginx # ingress-nginx has been deperecated | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo in "deperecated" - should be "deprecated".
Suggested change
|
||||||
| nginx.ingress.kubernetes.io/ssl-redirect: "true" | ||||||
| spec: | ||||||
| tls: | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -27,7 +27,7 @@ EOF | |||||||||
| </Step> | ||||||||||
|
|
||||||||||
| <Step> | ||||||||||
| Install the NGINX `IngressController`. | ||||||||||
| [Deprecated]: [Deprecated]: [Deprecated]: Install the NGINX `IngressController`. | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||||||
|
|
||||||||||
| ```shell title="install ingress controller" | ||||||||||
| helm install ingress-nginx ingress-nginx/ingress-nginx \ | ||||||||||
|
|
||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -53,7 +53,7 @@ metadata: | |||||
| name: example-ingress | ||||||
| namespace: bar | ||||||
| spec: | ||||||
| ingressClassName: nginx | ||||||
| ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The deprecation comment appears twice. Consider using a single comment.
Suggested change
|
||||||
| rules: | ||||||
| - http: | ||||||
| paths: | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in "deperecated" - should be "deprecated".