Deprecate ingress nginx #1486

rmweir · 2025-12-11T23:51:21Z

Content Description

Preview Link

Internal Reference

Part of ENG-10314

@netlify /docs

Note

Adds deprecation notices for ingress-nginx across documentation.

Platform install: Added deprecation warnings to NGINX ingress controller sections
Platform config: Updated domain configuration with deprecation notice for NGINX
Sleep mode: Added deprecation markers to ingress-nginx references
Templates: Added deprecation comments to NGINX ingress class examples
vCluster config: Marked ingress-nginx addon and examples as deprecated
Integrations: Updated cert-manager docs with NGINX deprecation notices

^{Generated by Claude for 7ed094d}

netlify · 2025-12-11T23:51:26Z

✅ Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7ed094d`
🔍 Latest deploy log	https://app.netlify.com/projects/vcluster-docs-site/deploys/694526bfca01dc000847fc0c
😎 Deploy Preview	https://deploy-preview-1486--vcluster-docs-site.netlify.app/docs
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-12-11T23:51:47Z

ENG-10314: Deprecations for ingress-nginx in 0.31

cbron

Seems fine to me. @guowenatk can you review ?

loft-bot · 2025-12-19T09:38:35Z

Claude encountered an error —— View job

Command failed: git fetch origin --depth=20 deprecate-nginx

I'll analyze this and get back to you.

github-actions · 2025-12-19T09:38:39Z

Claude Code review failed to complete. This may be due to API rate limits or network issues. The PR can still be reviewed manually.

Piotr1215 · 2025-12-19T10:06:03Z

vcluster/_fragments/sleepmode-ingress-example.mdx


 <Step>
-Install the NGINX `IngressController`.
+[Deprecated]: [Deprecated]: [Deprecated]: Install the NGINX `IngressController`.


Suggested change

[Deprecated]: [Deprecated]: [Deprecated]: Install the NGINX `IngressController`.

[Deprecated]: Install the NGINX `IngressController`.

loft-bot · 2025-12-19T10:12:07Z

Claude encountered an error —— View job

Command failed: git fetch origin --depth=20 deprecate-nginx

I'll analyze this and get back to you.

github-actions · 2025-12-19T10:12:10Z

Claude Code review failed to complete. This may be due to API rate limits or network issues. The PR can still be reviewed manually.

loft-bot · 2025-12-19T10:20:00Z

Claude finished @rmweir's task in 2m 38s —— View job

Review: Deprecate ingress nginx

Summary: This PR adds deprecation notices for ingress-nginx across 21 documentation files. The changes appropriately mark NGINX ingress controller references as deprecated while keeping the documentation functional for users still using it.

Issues Found

I found several issues that need attention:

Typos (4 occurrences)

deperecated → deprecated in:
- platform/administer/clusters/advanced/multi-region-mode.mdx:22
- platform/administer/monitoring/aggregating-metrics.mdx:220
- platform/administer/templates/create-templates.mdx:549, 559
- vcluster/_fragments/integrations/cert-manager.mdx:417

Duplicate text (3 occurrences)

[Deprecated]: [Deprecated]: [Deprecated]: in vcluster/_fragments/sleepmode-ingress-example.mdx:30 - appears 3 times
Duplicate deprecation comments in YAML:
- vcluster/configure/vcluster-yaml/experimental/_code/sleepmode-ingress-examples.yaml:56
- vcluster/_fragments/integrations/cert-manager.mdx:281

Existing review comment from @Piotr1215
The reviewer suggested changing the format at line 30 of vcluster/_fragments/sleepmode-ingress-example.mdx. The current implementation has triple [Deprecated]: which looks like an unintended repetition.

What Looks Good

✅ Deprecation warnings are appropriately placed at section/step level
✅ YAML code examples properly annotated with deprecation comments
✅ :::warning Deprecated admonitions used correctly in appropriate files
✅ Validated vCluster YAML configurations are syntactically correct

loft-bot · 2025-12-19T10:22:07Z

vcluster/_fragments/sleepmode-ingress-example.mdx


 <Step>
-Install the NGINX `IngressController`.
+[Deprecated]: [Deprecated]: [Deprecated]: Install the NGINX `IngressController`.


The [Deprecated]: prefix appears three times. This looks like an accidental repetition.

Suggested change

[Deprecated]: [Deprecated]: [Deprecated]: Install the NGINX `IngressController`.

[Deprecated]: Install the NGINX `IngressController`.

loft-bot · 2025-12-19T10:22:11Z

vcluster/configure/vcluster-yaml/experimental/_code/sleepmode-ingress-examples.yaml

  namespace: bar
 spec:
-  ingressClassName: nginx
+  ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class


The deprecation comment appears twice. Consider using a single comment.

Suggested change

ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class

ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class

loft-bot · 2025-12-19T10:22:12Z

vcluster/_fragments/integrations/cert-manager.mdx

    - http01:
        ingress:
-          ingressClassName: nginx
+          ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class


The deprecation comment appears twice in this line. Consider consolidating.

Suggested change

ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class

ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class

loft-bot · 2025-12-19T10:22:13Z

platform/administer/clusters/advanced/multi-region-mode.mdx

  name: loft-agent-ingress
  annotations:
-    kubernetes.io/ingress.class: nginx
+    kubernetes.io/ingress.class: nginx # ingress-nginx has been deperecated


There's a typo in "deperecated" - should be "deprecated".

Suggested change

kubernetes.io/ingress.class: nginx # ingress-nginx has been deperecated

kubernetes.io/ingress.class: nginx # ingress-nginx has been deprecated

loft-bot · 2025-12-19T10:22:14Z

platform/administer/monitoring/aggregating-metrics.mdx

 ### Option 2: Ingress

-Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller:
+Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller (deperecated):


There's a typo in "deperecated" - should be "deprecated".

Suggested change

Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller (deperecated):

Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller (deprecated):

loft-bot · 2025-12-19T10:22:16Z

platform/administer/templates/create-templates.mdx

                  nginx.ingress.kubernetes.io/force-ssl-redirect: "true"
                  nginx.ingress.kubernetes.io/backend-protocol: "HTTP"
-                ingressClassName: "nginx"
+                ingressClassName: "nginx" # deperecated


There's a typo in "deperecated" - should be "deprecated".

Suggested change

ingressClassName: "nginx" # deperecated

ingressClassName: "nginx" # deprecated

loft-bot · 2025-12-19T10:22:17Z

platform/administer/templates/create-templates.mdx

              ingress:
                enabled: true
-                ingressClassName: "nginx"
+                ingressClassName: "nginx" # deperecated


There's a typo in "deperecated" - should be "deprecated".

Suggested change

ingressClassName: "nginx" # deperecated

ingressClassName: "nginx" # deprecated

loft-bot · 2025-12-19T10:22:19Z

vcluster/_fragments/integrations/cert-manager.mdx

  name: secure-app-ingress
  annotations:
-    kubernetes.io/ingress.class: nginx
+    kubernetes.io/ingress.class: nginx # ingress-nginx has been deperecated


There's a typo in "deperecated" - should be "deprecated".

Suggested change

kubernetes.io/ingress.class: nginx # ingress-nginx has been deperecated

kubernetes.io/ingress.class: nginx # ingress-nginx has been deprecated

rmweir requested a review from a team as a code owner December 11, 2025 23:51

rmweir force-pushed the deprecate-nginx branch 2 times, most recently from de4cb09 to dd29df9 Compare December 12, 2025 00:04

cbron reviewed Dec 12, 2025

View reviewed changes

cbron requested a review from guowenatk December 12, 2025 21:09

rmweir force-pushed the deprecate-nginx branch 2 times, most recently from 5274a3f to c437b52 Compare December 18, 2025 21:00

Piotr1215 force-pushed the deprecate-nginx branch from c437b52 to 0b19a51 Compare December 19, 2025 09:38

Piotr1215 reviewed Dec 19, 2025

View reviewed changes

Piotr1215 force-pushed the deprecate-nginx branch from 0b19a51 to bbe5391 Compare December 19, 2025 10:11

Deprecate ingress nginx

7ed094d

Piotr1215 force-pushed the deprecate-nginx branch from bbe5391 to 7ed094d Compare December 19, 2025 10:19

loft-bot reviewed Dec 19, 2025

View reviewed changes

	[Deprecated]: [Deprecated]: [Deprecated]: Install the NGINX `IngressController`.
	[Deprecated]: Install the NGINX `IngressController`.

	ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class # the ingress-nginx project has been deprecated, we recommend using a different ingress class
	ingressClassName: nginx # the ingress-nginx project has been deprecated, we recommend using a different ingress class

	kubernetes.io/ingress.class: nginx # ingress-nginx has been deperecated
	kubernetes.io/ingress.class: nginx # ingress-nginx has been deprecated

	Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller (deperecated):
	Create an Ingress resource to expose Grafana externally. The following example uses the nginx ingress controller (deprecated):

	ingressClassName: "nginx" # deperecated
	ingressClassName: "nginx" # deprecated

Deprecate ingress nginx #1486

Are you sure you want to change the base?

Deprecate ingress nginx #1486

Uh oh!

Conversation

rmweir commented Dec 11, 2025 • edited by loft-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content Description

Preview Link

Internal Reference

Uh oh!

netlify bot commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vcluster-docs-site ready!

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

cbron left a comment

Choose a reason for hiding this comment

Uh oh!

loft-bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

loft-bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 19, 2025

Uh oh!

loft-bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review: Deprecate ingress nginx

Issues Found

What Looks Good

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rmweir commented Dec 11, 2025 •

edited by loft-bot

Loading

netlify bot commented Dec 11, 2025 •

edited

Loading

loft-bot commented Dec 19, 2025 •

edited

Loading

loft-bot commented Dec 19, 2025 •

edited

Loading

loft-bot commented Dec 19, 2025 •

edited

Loading