Fix for #13094 #14088
Merged
Fix for #13094 #14088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you add a description that more fully explains what you're doing and is suitable as a merge commit note? |
Contributor
Author
Done. |
Collaborator
|
That describes the code mechanically, I'm thinking more like "what is this fixing, why does it fix this?" |
Contributor
Author
|
When using EGL with X11 on an NVIDIA system, the eglCreateWindowSurface call fails due to a EGL_BAD_ATTRIBUTE error, this error comes from the EGL_DISPLAY extension being used. This PR fixes this by retrying surface creation without the EGL_DISPLAY extension if eglCreateWindowSurface errors out with EGL_BAD_ATTRIBUTE . |
Collaborator
|
Perfect, thanks! |
Collaborator
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an use_opaque_ext variable to SDL_EGL_CreateSurface. If surface creation fails due to a EGL_BAD_ATTRIBUTE error, this variable is set to false, and the function jumps back to the start.