SDL2: Creating an EGL window fails on Linux with Nvidia GPU

[toadster172]

Platform: Ubuntu 24.04, X11, Nvidia 535 drivers

Calls to SDL_CreateWindow using that use EGL fail due to the call to eglCreateWindowSurface from SDL_EGL_CreateSurface failing with EGL_BAD_ATTRIBUTE. The only attribute provided is EGL_PRESENT_OPAQUE_EXT, which SDL seems to always add if the driver reports SDL_EGL_DISPLAY_EXTENSION as present. For whatever reason, Nvidia drivers report the extension and then reject the attribute anyway.

[eafton]

Does this fix it for you? #14088

[icculus]

Sorry, just checking this again because the goto caught my eye: this doesn't reset attr to zero on the second try, so this PR needs further adjusting.

[icculus]

Also, EGL_EXT_present_opaque isn't listed by eglinfo for my GeForce RTX 4070 on X11 (driver 580.65.06)...do we actually need this fix now?

(and "SDL seems to always add if the driver reports SDL_EGL_DISPLAY_EXTENSION as present" isn't correct; that's an enum (verses SDL_EGL_CLIENT_EXTENSION) that is used when checking for EGL_EXT_present_opaque.)

[slouken]

Should we back out the PR?