Skip to content

chore(l1): allow PR title to begin with UPPERCASE #5519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JereSalo wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(l1): allow PR title to begin with UPPERCASE #5519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e49f08
allow uppercase title
JereSalo Dec 4, 2025
e3065b8
use pull_request instead of pull_request_target in pr lint title
JereSalo Dec 4, 2025
6b6c5e2
Merge branch 'main' into allow_uppercase_title
JereSalo Dec 4, 2025
5e4263c
make sure subject starts with a letter
JereSalo Dec 4, 2025
1448704
Merge branch 'allow_uppercase_title' of github.com:lambdaclass/ethrex…
JereSalo Dec 4, 2025
1d5d26b
Merge branch 'main' into allow_uppercase_title
JereSalo Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/pr_lint_pr_title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: PR title

on:
pull_request_target:
pull_request:
Copy link
Collaborator

@mpaulucci mpaulucci Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change this?

Copy link
Contributor Author

@JereSalo JereSalo Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason is in the PR description:
With pull_request_target the workflow that will run will be the one in main and with pull_request it will run the workflow in the current branch. So if I make changes to the workflow now the version of it that would run would be the one in my branch and not the old one (in main).

types:
- opened
- edited
Expand Down Expand Up @@ -57,16 +57,16 @@ jobs:
#disallowScopes: |

# Configure additional validation for the subject based on a regex.
# This example ensures the subject doesn't start with an uppercase character.
subjectPattern: ^(?![A-Z]).+$
# Require the subject to start with a letter.
subjectPattern: ^[A-Za-z].*$

# If `subjectPattern` is configured, you can use this property to override
# the default error message that is shown when the pattern doesn't match.
# The variables `subject` and `title` can be used within the message.
subjectPatternError: |
The subject "{subject}" found in the pull request title "{title}"
didn't match the configured pattern. Please ensure that the subject
doesn't start with an uppercase character.
didn't match the configured pattern. Please ensure the subject starts
with a letter.

# If the PR contains one of these newline-delimited labels, the
# validation is skipped. If you want to rerun the validation when
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ All PR titles must follow the enforced semantic format:
- **Allowed types:** `feat`, `fix`, `perf`, `refactor`, `revert`, `deps`, `build`, `ci`, `test`, `style`, `chore`, `docs`
- **Allowed scopes:** `l1`, `l2`, `levm` (multiple scopes can be used, separated by commas)
- **Scope(s) are required**
- **Subject must not start with an uppercase character**
- **Subject must start with a letter**

**Examples:**
- `fix(l1,levm): handle edge case in snap sync`
- `docs(l2): update documentation for L2`
- `docs(l2): Update documentation for L2`

An exclamation mark may be added before the colon to indicate breaking changes, for example `perf(l1)!: change database schema`

Expand Down