chore(l1): allow PR title to begin with UPPERCASE #5519
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the restriction that prevented PR titles from starting with uppercase characters. The change enables more natural sentence casing in PR titles while maintaining the semantic commit format requirements.
- Removed the lowercase-only constraint from PR title validation
- Updated documentation to reflect the new rule and provide an example with uppercase
- Changed workflow trigger from
pull_request_targettopull_requestfor immediate application
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CONTRIBUTING.md | Removed the requirement that subjects must not start with uppercase and updated example to demonstrate uppercase usage |
| .github/workflows/pr_lint_pr_title.yml | Commented out the regex pattern enforcing lowercase subjects and changed trigger to pull_request for immediate effect |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JereSalo
changed the title
mpaulucci
left a comment
mpaulucci
left a comment
There was a problem hiding this comment.
It still should be a letter A to Z, whether underscore or upperscore
… into allow_uppercase_title
Yeah, I agree. I changed it here, now it can only start with a letter. Thanks for noticing! |
|
|
||
| on: | ||
| pull_request_target: | ||
| pull_request: |
There was a problem hiding this comment.
why did you change this?
Motivation
Description
pull_request_targettopull_requestbecause this makes the workflow apply immediately. With pull_request_target the workflow that would've run would've been themainone, which still blocks uppercase characters.Edit: Had to change the title to lowercase because the old workflow is still running as it was a
pull_request_target😞Example job run https://github.com/lambdaclass/ethrex/actions/runs/19934067966/job/57153864030?pr=5519