-
Notifications
You must be signed in to change notification settings - Fork 15.1k
use genfeaturegates utility in k/k to update feature gate info
#53489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-1.35
Are you sure you want to change the base?
use genfeaturegates utility in k/k to update feature gate info
#53489
Conversation
Signed-off-by: Davanum Srinivas <[email protected]>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you for this great tool. I've noticed that when users want to understand the details of a feature gate, What do you think about including KEP search links in the generated output? This might be out of scope for this PR, but I wanted to share the idea |
|
@kfess i am putting the framework in place between the 2 repos. I am happy for folks to morph this as they see fit to add more things! (KEP owners, SIGs etc) |
|
/hold Only because some (just a few) of the files that this PR would add aren't yet complete. I want to call that out so we can decide how to handle that. Approvers for English, for the website overall, @dims, and of course SIG leadership: any of you can unhold this and you definitely wouldn't need to check with me before you do that. One option (there are others!) is to split this PR: the first part can add the tooling, the second part can update all the feature gates where we have a description for them, and a third manually-curated PR could add in the feature gates that are missing. If we have the appetite for it, we could also backport those changes to the v1.34 docs, or use the same automation against the v1.34 release. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I have no issues however you all want to handle this. please feel free to take it over as i won't have time. thanks, |
Using code being added to kubernetes main repo in:
kubernetes/kubernetes#135510
We need automation to keep the information in k/website fresh. in the above PR we are adding a utility which we can reuse here.
This essentially deprecates the custom gist i have been maintaining for a while:
https://gist.github.com/dims/a0ecf5de51235968e12b9d6b62ac3a83/
Description
Issue
Closes: #