Skip to content

Conversation

@haircommander
Copy link
Contributor

Description

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Oct 20, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2025
@netlify
Copy link

netlify bot commented Oct 20, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c6459d7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6925c5d9906f4d000800549d

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2025
@netlify
Copy link

netlify bot commented Oct 20, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c6459d7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6925c5d9fdea680008ac5cc6
😎 Deploy Preview https://deploy-preview-52820--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Urvashi0109
Copy link
Contributor

Hello @haircommander 👋, v1.35 Docs Team here again!

We are closing in on the deadline to get your PR ready for review before Tuesday 18th November 2025, so I'm sending a second reminder. Please take a look at the Documenting for a release - PR Ready for Review document to get your PR ready for review before the deadline.

Please also let us know once your PR is fully Ready for Review -- meaning all documentation updates are complete and it's awaiting reviewer feedback -- so we can update our tracking.

Thank you!

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 17, 2025
@haircommander haircommander changed the title KEP-4210: placeholder for GA KEP-4210: mark as stable Nov 17, 2025
@haircommander haircommander marked this pull request as ready for review November 17, 2025 20:41
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander The PR is currently lacking the change to transition the feature gate ImageMaximumGCAge from Beta to Stable. The necessary change should be made in the feature gate description file - ImageMaximumGCAge.md (here). Also, would also help if you include the upstream k/k implementation PR in the pull request description.

Please refer to the documentation here for further information.


#### Garbage collection for unused container images {#image-maximum-age-gc}

{{< feature-state feature_gate_name="ImageMaximumGCAge" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave the feature-state shortcode line in place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is GA. What would be the purpose of keeping it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we kept the shortcode for GA features.
I think usually aim to clean it up in later releases after the feature gate is removed. It is fine to remove the shortcode now and it does not block the merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it in helps people see that they'd better upgrade their cluster (imagine if they are running K8s 1.29), and if they work anywhere that has a policy like "beta features in production need signoff", it helps them spot that need for a sign off.

We typically drop mentioning the feature gate when it has been removed from Kubernetes, or if it has not been removed but is locked to true for all supported versions.


I have a PR to let you leave the shortcode in, and automatically get that rendered as a more helpful text explanation once the feature gate is marked as removed. @dims has a draft PR to automate setting feature gate metadata, per feature gate, for each minor release.

@sayanchowdhury
Copy link
Member

Hello @haircommander 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 3rd December 2025, 12:00 UTC.

This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander The PR is currently lacking the doc change to transition the feature gate ImageMaximumGCAge from Beta to Stable. The necessary change should be made in the feature gate description file - ImageMaximumGCAge.md (here).

Please refer to the documentation here for further information.

@dipesh-rawat
Copy link
Member

/lgtm cancel

Refer #52820 (review)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2025
@haircommander
Copy link
Contributor Author

updated!

Signed-off-by: Peter Hunt <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2025
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@dipesh-rawat
Copy link
Member

Taking previously applied tech lgtm (before the updating of feature gate stage) from #52820 (review)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b6b84c40a0624027dba18a2d6ecb2fb2552368f

@k8s-ci-robot k8s-ci-robot merged commit b79e620 into kubernetes:dev-1.35 Dec 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants