-
Notifications
You must be signed in to change notification settings - Fork 15.1k
KEP-4210: mark as stable #52820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4210: mark as stable #52820
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello @haircommander 👋, v1.35 Docs Team here again! We are closing in on the deadline to get your PR ready for review before Tuesday 18th November 2025, so I'm sending a second reminder. Please take a look at the Documenting for a release - PR Ready for Review document to get your PR ready for review before the deadline. Please also let us know once your PR is fully Ready for Review -- meaning all documentation updates are complete and it's awaiting reviewer feedback -- so we can update our tracking. Thank you! |
901c4d3 to
89e1adf
Compare
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haircommander The PR is currently lacking the change to transition the feature gate ImageMaximumGCAge from Beta to Stable. The necessary change should be made in the feature gate description file - ImageMaximumGCAge.md (here). Also, would also help if you include the upstream k/k implementation PR in the pull request description.
Please refer to the documentation here for further information.
|
|
||
| #### Garbage collection for unused container images {#image-maximum-age-gc} | ||
|
|
||
| {{< feature-state feature_gate_name="ImageMaximumGCAge" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the feature-state shortcode line in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is GA. What would be the purpose of keeping it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically we kept the shortcode for GA features.
I think usually aim to clean it up in later releases after the feature gate is removed. It is fine to remove the shortcode now and it does not block the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping it in helps people see that they'd better upgrade their cluster (imagine if they are running K8s 1.29), and if they work anywhere that has a policy like "beta features in production need signoff", it helps them spot that need for a sign off.
We typically drop mentioning the feature gate when it has been removed from Kubernetes, or if it has not been removed but is locked to true for all supported versions.
I have a PR to let you leave the shortcode in, and automatically get that rendered as a more helpful text explanation once the feature gate is marked as removed. @dims has a draft PR to automate setting feature gate metadata, per feature gate, for each minor release.
|
Hello @haircommander 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 3rd December 2025, 12:00 UTC. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as |
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haircommander The PR is currently lacking the doc change to transition the feature gate ImageMaximumGCAge from Beta to Stable. The necessary change should be made in the feature gate description file - ImageMaximumGCAge.md (here).
Please refer to the documentation here for further information.
|
/lgtm cancel Refer #52820 (review) |
89e1adf to
06eaf52
Compare
|
updated! |
content/en/docs/reference/command-line-tools-reference/feature-gates/ImageMaximumGCAge.md
Show resolved
Hide resolved
Signed-off-by: Peter Hunt <[email protected]>
06eaf52 to
c6459d7
Compare
dipesh-rawat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Taking previously applied tech lgtm (before the updating of feature gate stage) from #52820 (review) /lgtm |
|
LGTM label has been added. Git tree hash: 3b6b84c40a0624027dba18a2d6ecb2fb2552368f
|
Description
Issue
Closes: #