Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions content/en/docs/concepts/architecture/garbage-collection.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,7 @@ until disk usage reaches the `LowThresholdPercent` value.

#### Garbage collection for unused container images {#image-maximum-age-gc}

{{< feature-state feature_gate_name="ImageMaximumGCAge" >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave the feature-state shortcode line in place.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is GA. What would be the purpose of keeping it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we kept the shortcode for GA features.
I think usually aim to clean it up in later releases after the feature gate is removed. It is fine to remove the shortcode now and it does not block the merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping it in helps people see that they'd better upgrade their cluster (imagine if they are running K8s 1.29), and if they work anywhere that has a policy like "beta features in production need signoff", it helps them spot that need for a sign off.

We typically drop mentioning the feature gate when it has been removed from Kubernetes, or if it has not been removed but is locked to true for all supported versions.


I have a PR to let you leave the shortcode in, and automatically get that rendered as a more helpful text explanation once the feature gate is marked as removed. @dims has a draft PR to automate setting feature gate metadata, per feature gate, for each minor release.


As a beta feature, you can specify the maximum time a local image can be unused for,
You can specify the maximum time a local image can be unused for,
regardless of disk usage. This is a kubelet setting that you configure for each node.

To configure the setting, you need to set a value for the `imageMaximumGCAge`
Expand Down Expand Up @@ -207,4 +205,4 @@ configure garbage collection:

* Learn more about [ownership of Kubernetes objects](/docs/concepts/overview/working-with-objects/owners-dependents/).
* Learn more about Kubernetes [finalizers](/docs/concepts/overview/working-with-objects/finalizers/).
* Learn about the [TTL controller](/docs/concepts/workloads/controllers/ttlafterfinished/) that cleans up finished Jobs.
* Learn about the [TTL controller](/docs/concepts/workloads/controllers/ttlafterfinished/) that cleans up finished Jobs.
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,9 @@ stages:
- stage: beta
defaultValue: true
fromVersion: "1.30"
toVersion: "1.34"
- stage: stable
defaultValue: true
fromVersion: "1.35"
---
Enables the kubelet configuration field `imageMaximumGCAge`, allowing an administrator to specify the age after which an image will be garbage collected.