-
Notifications
You must be signed in to change notification settings - Fork 5.1k
UI: Manually added some lines for Ukrainian translation #21629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Andygol The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
7e6dd11
to
619260c
Compare
619260c
to
82c89fd
Compare
@Andygol: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andygol are you sure make extract is missing this ? this is part of automation and we need to fix the automation.
because if make extract is doing wrong, then it will overwrite the manual added strings
Yes, I do. I run
@medyagh As far as I know, make extract does not overwrite existing lines. UPD. I found a similar approach in other languages as well, when lines were added manually. (see Issue #21626) |
@kubernetes/minikube-maintainers Can we proceed with this PR for now, while the issue #21626 is being resolved? This PR contains only a few lines of translation (including typo fixes), which can be restored fairly quickly if the updated process for extracting lines for translation is implemented and these changes are removed. |
Some lines with Ukrainian translations that were not extracted by "make extract" have been added manually.
RE Issue: #21626