Skip to content

Conversation

Andygol
Copy link
Contributor

@Andygol Andygol commented Sep 24, 2025

Some lines with Ukrainian translations that were not extracted by "make extract" have been added manually.

RE Issue: #21626

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Andygol
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2025
@Andygol Andygol force-pushed the ukr-locale-missing-lines branch from 7e6dd11 to 619260c Compare September 24, 2025 14:19
@Andygol Andygol force-pushed the ukr-locale-missing-lines branch from 619260c to 82c89fd Compare September 24, 2025 14:32
@k8s-ci-robot
Copy link
Contributor

@Andygol: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-minikube-integration 82c89fd link true /test pull-minikube-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andygol are you sure make extract is missing this ? this is part of automation and we need to fix the automation.
because if make extract is doing wrong, then it will overwrite the manual added strings

@Andygol
Copy link
Contributor Author

Andygol commented Sep 24, 2025

@Andygol are you sure make extract is missing this ?

Yes, I do. I run make clean && make extract && make and than out/minikube <something> to visually check if something really changed.

then it will overwrite the manual added strings

@medyagh As far as I know, make extract does not overwrite existing lines.

UPD. I found a similar approach in other languages as well, when lines were added manually. (see Issue #21626)

@Andygol Andygol requested a review from medyagh September 24, 2025 21:40
@Andygol
Copy link
Contributor Author

Andygol commented Sep 30, 2025

@kubernetes/minikube-maintainers Can we proceed with this PR for now, while the issue #21626 is being resolved? This PR contains only a few lines of translation (including typo fixes), which can be restored fairly quickly if the updated process for extracting lines for translation is implemented and these changes are removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants