run the initial set of e2e prow job #21607
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| #!/usr/bin/env bash | ||
| OS=$(go env GOOS) | ||
| ARCH=$(go env GOARCH) | ||
| REPO_ROOT="$(git rev-parse --show-toplevel)" | ||
| make # build the binary first | ||
| LATEST_RELEASE=$(curl -sSfL https://dl.k8s.io/release/stable.txt) | ||
| "${REPO_ROOT}"/out/minikube start --nodes=2 --driver=docker --cpus=no-limit --memory=no-limit --force --kubernetes-version=$LATEST_RELEASE | ||
|
|
||
| kubetest2-tester-ginkgo --test-package-marker stable.txt \ | ||
| --focus-regex='\[Conformance\]' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| GOOS ?= $(shell go env GOOS) | ||
| GOARCH ?= $(shell go env GOARCH) | ||
|
|
||
| .PHONY: minikube-e2e-fast | ||
| minikube-e2e-fast: | ||
|
There was a problem hiding this comment. to avoid confusion how about name this folder test/conformance since we already have test/integration that we also call it e2e so I suggest using a name that makes it not overlap with others There was a problem hiding this comment. I'm thinking of splitting the tests like this: https://github.com/kubernetes/kops/tree/master/tests
I looked at common.sh and that harness can't be used in Prow. https://github.com/kubernetes/minikube/tree/master/hack/jenkins This needs to be removed entirely so lets start it from scratch using the sig-testing toolchain. There was a problem hiding this comment. we call our integration tests e2e in makefiles Line 288 in b374745 the e2e integration tests does also include testing different kubernetes versions. but I do like having , so for not making more confusing I suggest limiting this test to only confromacne test There was a problem hiding this comment. you can name the folder anything else and it would be better There was a problem hiding this comment.
I looked at the tests defined at #21607 (comment) and they are not kubernetes e2e tests. The kubernetes e2e tests are defined over here. Minikube needs to run these tests to verify kubernetes functionality. The default minikube config is already failing the simple e2e scenario we run. |
||
| ./tests/e2e/fast.sh | ||
|
|
||
| minikube-e2e-conformance: | ||
| ./tests/e2e/conformance.sh | ||
|
|
||
| integration-kvm-prow: #temp for prow | ||
| ./tests/e2e/fast.sh | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/usr/bin/env bash | ||
| OS=$(go env GOOS) | ||
| ARCH=$(go env GOARCH) | ||
| REPO_ROOT="$(git rev-parse --show-toplevel)" | ||
| make # build the binary first | ||
| LATEST_RELEASE=$(curl -sSfL https://dl.k8s.io/release/stable.txt) | ||
| "${REPO_ROOT}"/out/minikube start --nodes=2 --driver=docker --cpus=no-limit --memory=no-limit --force --kubernetes-version=$LATEST_RELEASE | ||
|
There was a problem hiding this comment. are two nodes required for this test "kubetest2-tester-ginkgo " ?if yes please comment. There was a problem hiding this comment. Yes, the default cluster size for testing is 1 control plane node and 3 worker nodes. 2 workers for kind e2e tests https://testgrid.k8s.io/sig-release-master-blocking#kind-master |
||
|
|
||
| kubetest2-tester-ginkgo --test-package-marker stable.txt \ | ||
| --parallel=30 \ | ||
| --skip-regex='\[Driver:.gcepd\]|\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]' | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script replaces https://github.com/kubernetes/minikube/blob/master/hack/conformance_tests.sh and we'll add minikube conformance(HEAD + supported branches) jobs to the main conformance board on testgrid at https://testgrid.k8s.io/conformance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you ! btw I am curious does this has to be shell script ? does prow accept go scripts ?
we try to convert as much as scripts to golang as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can write a kubetest2-minikube-deployer similar to this https://github.com/kubernetes/kops/tree/master/tests/e2e/kubetest2-kops
and its invoked like this: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kops/kops-presubmits-e2e.yaml#L348