run the initial set of e2e prow job #21607
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
|
Can one of the admins verify this patch? |
| #!/usr/bin/env bash | ||
| OS=$(go env GOOS) | ||
| ARCH=$(go env GOARCH) | ||
| REPO_ROOT="$(git rev-parse --show-toplevel)" |
There was a problem hiding this comment.
This script replaces https://github.com/kubernetes/minikube/blob/master/hack/conformance_tests.sh and we'll add minikube conformance(HEAD + supported branches) jobs to the main conformance board on testgrid at https://testgrid.k8s.io/conformance
There was a problem hiding this comment.
thank you ! btw I am curious does this has to be shell script ? does prow accept go scripts ?
we try to convert as much as scripts to golang as possible
There was a problem hiding this comment.
We can write a kubetest2-minikube-deployer similar to this https://github.com/kubernetes/kops/tree/master/tests/e2e/kubetest2-kops
and its invoked like this: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kops/kops-presubmits-e2e.yaml#L348
upodroid
force-pushed
the
initial-prow-e2e-jobs
branch
2 times, most recently
from
9d9242e to
f8c0432
Compare
| GOARCH ?= $(shell go env GOARCH) | ||
|
|
||
| .PHONY: minikube-e2e-fast | ||
| minikube-e2e-fast: |
There was a problem hiding this comment.
to avoid confusion how about name this folder test/conformance
since we already have test/integration that we also call it e2e
and we have "functional test" and "smoke test"
so I suggest using a name that makes it not overlap with others
There was a problem hiding this comment.
I'm thinking of splitting the tests like this:
https://github.com/kubernetes/kops/tree/master/tests
- integration is getting a successful minikube cluster up and running on all the permutations of arch/os/driver. Its purely specific to minikube
- e2e test is running the kubernetes test suite on a combination of minikube setups with various kubernetes versions
- minikube defaults with conformance + fast suite
- different CNI/Addons/hardware combinations against the fast suite
- smoke test which is compile minikube + launch it on docker, a base test scenario that runs on presubmits all the time
I looked at common.sh and that harness can't be used in Prow. https://github.com/kubernetes/minikube/tree/master/hack/jenkins This needs to be removed entirely so lets start it from scratch using the sig-testing toolchain.
There was a problem hiding this comment.
we call our integration tests e2e in makefiles
Line 288 in b374745
the e2e integration tests does also include testing different kubernetes versions. but I do like having , so for not making more confusing I suggest limiting this test to only confromacne test
There was a problem hiding this comment.
you can name the folder anything else and it would be better
for example
conformance, kubetest-e2e, ginkgo-e2e...
There was a problem hiding this comment.
we call our integration tests e2e in makefiles
Line 288 in b374745
the e2e integration tests does also include testing different kubernetes versions. but I do like having , so for not making more confusing I suggest limiting this test to only confromacne test
I looked at the tests defined at #21607 (comment) and they are not kubernetes e2e tests. The kubernetes e2e tests are defined over here. Minikube needs to run these tests to verify kubernetes functionality. The default minikube config is already failing the simple e2e scenario we run.
upodroid
force-pushed
the
initial-prow-e2e-jobs
branch
from
f8c0432 to
714f73b
Compare
upodroid
force-pushed
the
initial-prow-e2e-jobs
branch
from
714f73b to
8bb8c25
Compare
|
@upodroid: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The fast test suite is failing for the following reasons:
|
| REPO_ROOT="$(git rev-parse --show-toplevel)" | ||
| make # build the binary first | ||
| LATEST_RELEASE=$(curl -sSfL https://dl.k8s.io/release/stable.txt) | ||
| "${REPO_ROOT}"/out/minikube start --nodes=2 --driver=docker --cpus=no-limit --memory=no-limit --force --kubernetes-version=$LATEST_RELEASE |
There was a problem hiding this comment.
are two nodes required for this test "kubetest2-tester-ginkgo " ?if yes please comment.
There was a problem hiding this comment.
Yes, the default cluster size for testing is 1 control plane node and 3 worker nodes. 2 workers for kind e2e tests
https://testgrid.k8s.io/sig-release-master-blocking#kind-master
https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-default
Part of #20887