Skip to content

🧪 Updated workflow to accept test name #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshveta wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

🧪 Updated workflow to accept test name #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/global-ci-bundle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ on:
default: main
ui_tests_ref:
description: |
The branch or PR of the tackle-ui-tests repository to clone.
The branch or PR of the tackle2-ui repository to clone.
For a pull request, the reference format would be "refs/pull/${PR_NUMBER}/merge".
For a branch, the reference format would just be the branch name.
This input can be set automatically on a pull request by adding a string of the format:
Expand All @@ -144,6 +144,13 @@ on:
required: false
type: string
default: "@ci"
ui_test_spec:
description: |
A comma separated list of test file paths to run (overrides ui_test_tags).
For example: "administration/credentials/*.test.ts,migration/controls/**/*.test.ts"
required: false
type: string
default: ""

workflow_dispatch:
inputs:
Expand Down Expand Up @@ -202,7 +209,7 @@ on:
default: make test-tier0 test-tier1
ui_tests_ref:
description: |
The branch or PR of the tackle-ui-tests repository to clone.
The branch or PR of the tackle2-ui repository to clone.
For a pull request, the reference format would be "refs/pull/${PR_NUMBER}/merge".
For a branch, the reference format would just be the branch name.
This input can be set automatically on a pull request by adding a string of the format:
Expand All @@ -220,6 +227,13 @@ on:
required: false
type: string
default: "@ci"
ui_test_spec:
description: |
A comma separated list of test file paths to run (overrides ui_test_tags).
For example: "administration/credentials/*.test.ts,migration/controls/**/*.test.ts"
required: false
type: string
default: ""

env:
operator_bundle: ttl.sh/konveyor-operator-bundle-${{ github.sha }}:4h
Expand Down Expand Up @@ -496,5 +510,6 @@ jobs:
uses: konveyor/tackle2-ui/.github/actions/run-ui-tests@main
with:
test_tags: ${{ inputs.ui_test_tags }}
test_spec: ${{ inputs.ui_test_spec }}
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Try to fetch the action.yml file from the tackle2-ui repository
# Using raw GitHub content URL
echo "=== Checking action.yml for test_spec support ==="
curl -s "https://raw.githubusercontent.com/konveyor/tackle2-ui/main/.github/actions/run-ui-tests/action.yml" | head -100

Repository: konveyor/ci

Length of output: 3023

🌐 Web query:

konveyor tackle2-ui PR 2829 test_spec parameter github

💡 Result:

I couldn't find a Konveyor tackle2-ui pull request #2829 or any reference to a test_spec parameter matching that PR. Do you have a link, exact repo (GitHub vs mirror), or the PR number to check? I can search GitHub and return the PR details and file/parameter changes once you confirm.

The action does not support the test_spec parameter as an input.

The konveyor/tackle2-ui/.github/actions/run-ui-tests@main action only accepts three inputs: test_tags, tests_ref, and base_url. The test_spec parameter passed on line 513 is not defined in the action's inputs and will be silently ignored. The action internally generates test_spec from test_tags via the "Build test spec from test tags" step.

Either update the action to accept and use test_spec as an input parameter (which would allow it to override the tags-based spec generation), or remove this parameter from the workflow call.

🤖 Prompt for AI Agents 
In @.github/workflows/global-ci-bundle.yml at line 513, The workflow is passing
an unsupported input "test_spec" to the action
konveyor/tackle2-ui/.github/actions/run-ui-tests@main; either remove the
test_spec line from the workflow invocation (so only test_tags, tests_ref, and
base_url are passed) or update the action implementation (action metadata and
entrypoint) to declare a "test_spec" input and use it to override the internal
spec generation (ensure the code that currently builds test_spec from test_tags
checks for a non-empty inputs.test_spec and uses that instead).

tests_ref: ${{ env.UI_TESTS_REF }}
base_url: ${{ env.UI_URL }}
Loading