Conversation
Signed-off-by: Shveta Sachdeva <sshveta@redhat.com>
📝 WalkthroughWalkthroughA new workflow input Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/global-ci-bundle.yml:
- Line 513: The workflow is passing an unsupported input "test_spec" to the
action konveyor/tackle2-ui/.github/actions/run-ui-tests@main; either remove the
test_spec line from the workflow invocation (so only test_tags, tests_ref, and
base_url are passed) or update the action implementation (action metadata and
entrypoint) to declare a "test_spec" input and use it to override the internal
spec generation (ensure the code that currently builds test_spec from test_tags
checks for a non-empty inputs.test_spec and uses that instead).
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/global-ci-bundle.yml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: aufi
Repo: konveyor/ci PR: 97
File: .github/workflows/global-ci-bundle.yml:141-145
Timestamp: 2025-06-26T06:08:36.244Z
Learning: In the global-ci-bundle.yml workflow, the base_tag parameter is primarily designed for automated workflow_call executions, not manual workflow_dispatch usage. For workflow_call, operator_bundle defaults to empty so make-bundle runs and uses base_tag. For workflow_dispatch (web UI), operator_bundle has a default value, so users need to manually clear it to use base_tag.
📚 Learning: 2025-06-26T06:08:36.244Z
Learnt from: aufi
Repo: konveyor/ci PR: 97
File: .github/workflows/global-ci-bundle.yml:141-145
Timestamp: 2025-06-26T06:08:36.244Z
Learning: In the global-ci-bundle.yml workflow, the base_tag parameter is primarily designed for automated workflow_call executions, not manual workflow_dispatch usage. For workflow_call, operator_bundle defaults to empty so make-bundle runs and uses base_tag. For workflow_dispatch (web UI), operator_bundle has a default value, so users need to manually clear it to use base_tag.
Applied to files:
.github/workflows/global-ci-bundle.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Verify api and ui tests run via
global-ci-bundle.ymlwith default input / e2e-ui-integration-tests - GitHub Check: Verify api and ui tests run via
global-ci-bundle.ymlwith default input / e2e-api-integration-tests - GitHub Check: Verify api and ui tests run via
global-ci.ymlwith default inputs / e2e-ui-integration-tests - GitHub Check: Verify api and ui tests run via
global-ci.ymlwith default inputs / e2e-api-integration-tests
🔇 Additional comments (3)
.github/workflows/global-ci-bundle.yml (3)
147-153: LGTM! Well-structured input parameter.The new
ui_test_specinput is properly defined with clear documentation and an appropriate default value that maintains backward compatibility.
230-236: LGTM! Consistent with workflow_call definition.The
ui_test_specinput forworkflow_dispatchcorrectly mirrors theworkflow_calldefinition, maintaining consistency across trigger types.
129-129: The repository name in the descriptions (lines 129 and 212) is correct. Thekonveyor/tackle2-uirepository is the official Konveyor Tackle UI repository, and these descriptions accurately align with the action reference at line 510 (konveyor/tackle2-ui/.github/actions/run-ui-tests@main). No changes needed.
| uses: konveyor/tackle2-ui/.github/actions/run-ui-tests@main | ||
| with: | ||
| test_tags: ${{ inputs.ui_test_tags }} | ||
| test_spec: ${{ inputs.ui_test_spec }} |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Try to fetch the action.yml file from the tackle2-ui repository
# Using raw GitHub content URL
echo "=== Checking action.yml for test_spec support ==="
curl -s "https://raw.githubusercontent.com/konveyor/tackle2-ui/main/.github/actions/run-ui-tests/action.yml" | head -100Repository: konveyor/ci
Length of output: 3023
🌐 Web query:
konveyor tackle2-ui PR 2829 test_spec parameter github
💡 Result:
I couldn't find a Konveyor tackle2-ui pull request #2829 or any reference to a test_spec parameter matching that PR. Do you have a link, exact repo (GitHub vs mirror), or the PR number to check? I can search GitHub and return the PR details and file/parameter changes once you confirm.
The action does not support the test_spec parameter as an input.
The konveyor/tackle2-ui/.github/actions/run-ui-tests@main action only accepts three inputs: test_tags, tests_ref, and base_url. The test_spec parameter passed on line 513 is not defined in the action's inputs and will be silently ignored. The action internally generates test_spec from test_tags via the "Build test spec from test tags" step.
Either update the action to accept and use test_spec as an input parameter (which would allow it to override the tags-based spec generation), or remove this parameter from the workflow call.
🤖 Prompt for AI Agents
In @.github/workflows/global-ci-bundle.yml at line 513, The workflow is passing
an unsupported input "test_spec" to the action
konveyor/tackle2-ui/.github/actions/run-ui-tests@main; either remove the
test_spec line from the workflow invocation (so only test_tags, tests_ref, and
base_url are passed) or update the action implementation (action metadata and
entrypoint) to declare a "test_spec" input and use it to override the internal
spec generation (ensure the code that currently builds test_spec from test_tags
checks for a non-empty inputs.test_spec and uses that instead).
Related PR konveyor/tackle2-ui#2829
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.