Address data issues that are causing the MSK-IMPACT studies to fail validation#1293
Draft
jamesqo wants to merge 5 commits into
Draft
Address data issues that are causing the MSK-IMPACT studies to fail validation#1293jamesqo wants to merge 5 commits into
jamesqo wants to merge 5 commits into
Conversation
jamesqo
commented
Feb 4, 2026
| for (String gene : genes) { | ||
| StringBuilder line = new StringBuilder(gene); | ||
| for (String sample : samples) { | ||
| String cnaValue = "0"; |
Contributor
Author
There was a problem hiding this comment.
note: consider whether "0" or "NA" should be the default value in such cases
Contributor
Author
There was a problem hiding this comment.
In both cases (diploid / NA) there isn't a record added to the database, so they're equivalent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NAinstead of blanks in CNA, gene panel, clinical sample data