Skip to content

Add durable proxy acceptance fixtures - #92

Merged
IlyaasK merged 1 commit into
mainfrom
hypeship/proxy-acceptance-fixture
Jul 29, 2026
Merged

Add durable proxy acceptance fixtures#92
IlyaasK merged 1 commit into
mainfrom
hypeship/proxy-acceptance-fixture

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add durable proxy create/delete calls to the provider-local Kernel client
  • add guarded, project-scoped proxy cleanup for acceptance fixtures
  • verify mutation scope, disabled retries, cleanup deadlines, 404 handling, and error reporting
  • keep the SDK proxy health-check operation outside the provider client surface

Why this is v0 work

The kernel_proxy data source needs a real managed datacenter proxy fixture for live acceptance coverage. These helpers create and clean up that durable fixture without adding a Terraform proxy resource or runtime proxy operations.

Tests

  • go test -short -timeout=2m ./...
  • go test -race -short -timeout=2m ./internal/kernelclient ./internal/acctest
  • go vet ./...
  • go mod verify
  • go mod tidy -diff
  • terraform fmt -check -recursive examples
  • bash scripts/check-markdown-links.sh
  • bash scripts/check-docs.sh
  • git diff --check
  • gofmt -l cmd internal

Acceptance status

No live API test is added in this fixture-only PR. The stacked proxy data-source acceptance PR creates the managed datacenter proxy and exercises cleanup.

Intentionally unsupported

  • no Terraform proxy resource
  • no custom proxy credential management
  • no proxy health checks
  • no browser/session runtime operations

Note

Low Risk
Changes are limited to test infrastructure and thin API client wrappers; no provider runtime or auth paths are modified.

Overview
Adds project-scoped proxy create/delete on the provider kernelclient (mutations use disabled SDK retries, same as other resources) and CleanupProxy acceptance helpers with unit tests for env gates, default vs explicit project, 404-as-clean, deadlines, and delete errors. A reflect test documents that CheckProxy is intentionally not on the client surface.

Also wires live kernel_profile data source acceptance (API-created fixture, cleanup + post-cleanup verification) and extends the acceptance workflow matrix to run ./internal/datasources/profile with KERNEL_PROJECT_ID required.

No Terraform proxy resource or proxy data-source acceptance in this diff; proxy helpers are fixture-only for a follow-on PR.

Reviewed by Cursor Bugbot for commit fb0ef06. Bugbot is set up for automated code reviews on this repo. Configure here.

@IlyaasK
IlyaasK marked this pull request as ready for review July 11, 2026 18:27
@IlyaasK
IlyaasK requested review from Sayan- and tnsardesai and removed request for Sayan- and tnsardesai July 11, 2026 18:27
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from 18e374c to f3131d6 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from 0d5cd8c to 85aa723 Compare July 13, 2026 13:35
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from f3131d6 to dcf7b87 Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from 85aa723 to 9efab09 Compare July 13, 2026 14:32
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from dcf7b87 to e81feb3 Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from 9efab09 to 18d0ba6 Compare July 13, 2026 15:39
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from 18d0ba6 to f69c074 Compare July 20, 2026 19:37
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from 9148711 to 6d545f6 Compare July 21, 2026 14:46
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from f69c074 to 1d90c74 Compare July 21, 2026 14:46
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from 6d545f6 to acf09bb Compare July 21, 2026 18:10
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch 3 times, most recently from 8de340c to d4fbaf8 Compare July 21, 2026 20:15
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from 00082ec to bfef988 Compare July 27, 2026 20:01
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from d4fbaf8 to 5af11e7 Compare July 27, 2026 21:16
@IlyaasK
IlyaasK requested a review from Sayan- July 29, 2026 13:58
@IlyaasK
IlyaasK force-pushed the hypeship/profile-data-source-acceptance branch from bfef988 to c2d40a7 Compare July 29, 2026 14:15
@IlyaasK
IlyaasK force-pushed the hypeship/proxy-acceptance-fixture branch from 5af11e7 to fb0ef06 Compare July 29, 2026 18:59
@IlyaasK
IlyaasK changed the base branch from hypeship/profile-data-source-acceptance to main July 29, 2026 18:59
@IlyaasK
IlyaasK merged commit 0dd458b into main Jul 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants