Test proxy data source against Kernel - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel_proxylookup by ID and nameWhy
PR #93 was merged into the already-merged #92 head branch instead of
main, so its code did not reach the canonical branch. This PR reapplies only that reviewed two-file change directly onto currentmain.Scope
This adds acceptance coverage only. It does not change provider behavior, proxy CRUD behavior, Terraform schema, or runtime/session operations.
Verification
gofmt -l cmd internalgo test -short -timeout=2m ./...go vet ./...terraform fmt -check -recursive examplesLive acceptance remains opt-in through the manual acceptance workflow.
Note
Low Risk
Test and CI matrix changes only; no provider schema or runtime behavior is modified.
Overview
Adds live acceptance tests for
kernel_proxyand wires them into the manual Acceptance workflow matrix (project ID required).TestAccProxyDataSourceByIDAndNamecreates a datacenter proxy via the API, then reads it through Terraform by id + project_id and by name. Assertions cover expected metadata (type,protocol), project_id only on the ID lookup, absence of sensitive/runtime fields (username,password,status,ip_address), and a plan-only step to confirm no drift. Fixture helpers register cleanup and verify the proxy is gone after the test.Reviewed by Cursor Bugbot for commit 4f9b0d4. Bugbot is set up for automated code reviews on this repo. Configure here.