Skip to content

Update preset map values for paligemma2 #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update preset map values for paligemma2 #2440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 17 additions & 21 deletions tools/checkpoint_conversion/convert_pali_gemma2_checkpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,27 +63,23 @@
FLAGS = flags.FLAGS

PRESET_MAP = {
"pali_gemma2_3b_ft_docci_448": (
"google/paligemma-2/jax/paligemma2-3b-ft-docci-448"
),
"pali_gemma2_10b_ft_docci_448": (
"google/paligemma-2/jax/paligemma2-10b-ft-docci-448"
),
"pali_gemma2_3b_mix_224": "google/paligemma-2/jax/paligemma2-3b-mix-224",
"pali_gemma2_3b_mix_448": "google/paligemma-2/jax/paligemma2-3b-mix-448",
"pali_gemma2_10b_mix_224": "google/paligemma-2/jax/paligemma2-10b-mix-224",
"pali_gemma2_10b_mix_448": "google/paligemma-2/jax/paligemma2-10b-mix-448",
"pali_gemma2_28b_mix_224": "google/paligemma-2/jax/paligemma2-28b-mix-224",
"pali_gemma2_28b_mix_448": "google/paligemma-2/jax/paligemma2-28b-mix-448",
"pali_gemma2_3b_pt_224": "google/paligemma-2/jax/paligemma2-3b-pt-224",
"pali_gemma2_3b_pt_448": "google/paligemma-2/jax/paligemma2-3b-pt-448",
"pali_gemma2_3b_pt_896": "google/paligemma-2/jax/paligemma2-3b-pt-896",
"pali_gemma2_10b_pt_224": "google/paligemma-2/jax/paligemma2-10b-pt-224",
"pali_gemma2_10b_pt_448": "google/paligemma-2/jax/paligemma2-10b-pt-448",
"pali_gemma2_10b_pt_896": "google/paligemma-2/jax/paligemma2-10b-pt-896",
"pali_gemma2_28b_pt_224": "google/paligemma-2/jax/paligemma2-28b-pt-224",
"pali_gemma2_28b_pt_448": "google/paligemma-2/jax/paligemma2-28b-pt-448",
"pali_gemma2_28b_pt_896": "google/paligemma-2/jax/paligemma2-28b-pt-896",
"pali_gemma_2_ft_docci_3b_448": "google/paligemma2-3b-ft-docci-448-jax",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency in the preset naming. This key pali_gemma_2_ft_docci_3b_448 uses _2_, while all other paligemma2 presets use pali_gemma2_. For consistency, please consider renaming this to pali_gemma2_ft_docci_3b_448.1

Suggested change
"pali_gemma_2_ft_docci_3b_448": "google/paligemma2-3b-ft-docci-448-jax",
"pali_gemma2_ft_docci_3b_448": "google/paligemma2-3b-ft-docci-448-jax",

Style Guide References

Footnotes

  1. The style guide emphasizes that strict adherence to naming conventions is crucial for predictability and maintainability. The suggested change improves naming consistency across presets. ↩

"pali_gemma2_ft_docci_10b_448": "google/paligemma2-10b-ft-docci-448",
"pali_gemma2_mix_3b_224": "google/paligemma2-3b-mix-224",
"pali_gemma2_mix_3b_448": "google/paligemma2-3b-mix-448",
"pali_gemma2_mix_10b_224": "google/paligemma2-10b-mix-224",
"pali_gemma2_mix_10b_448": "google/paligemma2-10b-mix-448-jax",
"pali_gemma2_mix_28b_224": "google/paligemma2-28b-mix-224",
"pali_gemma2_mix_28b_448": "google/paligemma2-28b-mix-448-jax",
"pali_gemma2_pt_3b_224": "google/paligemma2-3b-pt-224-jax",
"pali_gemma2_pt_3b_448": "google/paligemma2-3b-pt-448",
"pali_gemma2_pt_3b_896": "google/paligemma2-3b-pt-896",
"pali_gemma2_pt_10b_224": "google/paligemma2-10b-pt-224",
"pali_gemma2_pt_10b_448": "google/paligemma2-10b-pt-448",
"pali_gemma2_pt_10b_896": "google/paligemma2-10b-pt-896",
"pali_gemma2_pt_28b_224": "google/paligemma2-28b-pt-224",
"pali_gemma2_pt_28b_448": "google/paligemma2-28b-pt-448",
"pali_gemma2_pt_28b_896": "google/paligemma2-28b-pt-896",
}


Expand Down
Loading