Skip to content

Conversation

@mehtamansi29
Copy link
Collaborator

Updated preset_map dictionary for paligemma2 with correct identifiers

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mehtamansi29, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the PRESET_MAP dictionary within the paligemma2 checkpoint conversion tool. The changes ensure that the mapping between model configurations and their respective paths is accurate and up-to-date, which is essential for the correct functioning of the conversion process.

Highlights

  • Preset Map Update: The PRESET_MAP dictionary in convert_pali_gemma2_checkpoints.py has been updated to reflect correct identifiers and paths for paligemma2 models.
  • Identifier Correction: Keys within the PRESET_MAP were adjusted for consistency, and some corresponding values (model paths) were modified to ensure accuracy, including changes related to 'jax' identifiers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the Gemma Gemma model specific issues label Oct 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PRESET_MAP dictionary in convert_pali_gemma2_checkpoints.py with new identifiers for paligemma2 models. The changes align the keys and values with what seems to be the new standard. I've pointed out a minor naming inconsistency in one of the new preset keys to improve maintainability, in line with our style guide.

"pali_gemma2_28b_pt_224": "google/paligemma-2/jax/paligemma2-28b-pt-224",
"pali_gemma2_28b_pt_448": "google/paligemma-2/jax/paligemma2-28b-pt-448",
"pali_gemma2_28b_pt_896": "google/paligemma-2/jax/paligemma2-28b-pt-896",
"pali_gemma_2_ft_docci_3b_448": "google/paligemma2-3b-ft-docci-448-jax",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an inconsistency in the preset naming. This key pali_gemma_2_ft_docci_3b_448 uses _2_, while all other paligemma2 presets use pali_gemma2_. For consistency, please consider renaming this to pali_gemma2_ft_docci_3b_448.1

Suggested change
"pali_gemma_2_ft_docci_3b_448": "google/paligemma2-3b-ft-docci-448-jax",
"pali_gemma2_ft_docci_3b_448": "google/paligemma2-3b-ft-docci-448-jax",

Style Guide References

Footnotes

  1. The style guide emphasizes that strict adherence to naming conventions is crucial for predictability and maintainability. The suggested change improves naming consistency across presets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gemma Gemma model specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant