Repository navigation
Let a checkout opt out of its repository's pre-commit configuration - #88
Merged
Merged
Conversation
Upstream repositories such as LFortran ship a .pre-commit-config.yaml their contributors never run; its clang-format rewrites whole files, so every commit there would carry an unrelated reformat. hooks.repoPreCommit=false skips that configuration for one checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared hook runs a repository's own
.pre-commit-config.yaml(pre-commit#L74). Some upstream repositories ship one that their contributors never run. LFortran pins clang-format 13 with-i, so a 24-line fix toasr_to_wasm.cppbecomes a 2120-line reformat of the whole file.A checkout can now opt out with
git config hooks.repoPreCommit false; the hook then reports that it skipped the repository's checks. Hygiene and Fo checks still run, and repositories without the setting behave as before.Checked in a scratch repository whose configuration records its run: unset and
truerun it,falseskips it with the message.bash -nand shellcheck are clean.Chris&AI