Repository navigation
Run Fo's commit check unbounded again - #89
Merged
Merged
Conversation
fo hook pre-commit --bounded accepts only a complete fast tier within its deadline; projects with many fast tests (fortfem: 867) never reach it, so every commit failed. Also update the installer checksum, which #88 left stale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since f9e7008 the hook runs
fo hook pre-commit --bounded. Bounded mode accepts a staged view only when every fast test passed within its deadline (fo_hook.f90#L465-L469), while the unbounded run it asks for defers tests beyond its budget and never records a complete pass. A project with many fast tests can therefore never commit; fortfem (867 fast tests) fails every time with "staged verification incomplete; prepare with: fo hook pre-commit".The hook calls
fo hook pre-commitwithout--boundedagain, as before f9e7008. It also updateshook_sha256ingit-hooks.sh, which #88 left stale, so the colleague installer failed its checksum.Checked:
bash -nand shellcheck clean;git-hooks.shinstalls into an empty home directory.Chris&AI