-
Notifications
You must be signed in to change notification settings - Fork 0
IBX-10621: Checkboxes List #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a Checkboxes List component as part of IBX-10621, introducing reusable components for handling lists of checkboxes and radio buttons. The implementation creates a new trait to share common functionality between radio button and checkbox list fields, along with corresponding TypeScript components for client-side interaction.
Key changes:
- Extracted common list field functionality into a reusable
ListFieldTrait
- Added a new
Checkbox\ListField
component for handling checkbox lists - Refactored existing
RadioButton\ListField
to use the shared trait - Created TypeScript components for checkbox list field interactions
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/lib/Twig/Components/ListFieldTrait.php |
New trait providing shared functionality for list-based form fields |
src/lib/Twig/Components/Checkbox/ListField.php |
New checkbox list field component implementation |
src/lib/Twig/Components/RadioButton/ListField.php |
Refactored to use the new ListFieldTrait |
src/lib/Twig/Components/AbstractField.php |
Removed generic value property to allow component-specific implementations |
src/bundle/Resources/public/ts/components/checkbox/checkboxes_list_field.ts |
New TypeScript component for checkbox list field interactions |
eslint.config.mjs |
Updated ESLint configuration with syntax fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/bundle/Resources/public/ts/components/checkbox/checkboxes_list_field.ts
Outdated
Show resolved
Hide resolved
{ | ||
files: ['**/*.ts'], | ||
rules: { | ||
'@typescript-eslint/unbound-method': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've switched it off because it returns false-positive on https://github.com/ibexa/design-system-twig/pull/49/files#diff-914f9d057f37b814c2bb03196746b89ce20143f6ece03374618eb28d2472d225R76
Basically linter for TS is not able to recognize if method was bound in constructor (typescript-eslint/typescript-eslint#636), as it's our common way for binding I think switching it off globally is better than leave it globally and switching it off per usecase
f3e4bb4
to
0f6c28a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GrabowskiM / @dew326 Could you also please involve PHP Team into review process ?
635895c
to
9135ce4
Compare
a4547ec
to
83b8615
Compare
83b8615
to
a75bbb3
Compare
Related PRs:
Description:
For QA:
Documentation: