CR

Author: mikadamczyk

src/lib/Twig/Components/ListFieldTrait.php

@@ -20,16 +20,21 @@
  */
 trait ListFieldTrait
 {
-    public string $direction = 'vertical';
+    private const string VERTICAL = 'vertical';
+    private const string HORIZONTAL = 'horizontal';
+
+    public string $direction = self::VERTICAL;
 
     /** @var ListItems */
     #[ExposeInTemplate(name: 'items', getter: 'getItems')]
     public array $items = [];
 
-    /** @return ListItems */
+    /**
+     * @return ListItems
+     */
     public function getItems(): array
     {
-        return array_map(function ($item) {
+        return array_map(function (array $item) {
             $listItem = $item + ['name' => $this->name, 'required' => $this->required];
 
             return $this->modifyListItem($listItem);
@@ -55,7 +60,7 @@ protected function validateListFieldProps(OptionsResolver $resolver): void
 
         $resolver
             ->define('direction')
-            ->allowedValues('vertical', 'horizontal')
-            ->default('vertical');
+            ->allowedValues(self::VERTICAL, self::HORIZONTAL)
+            ->default(self::VERTICAL);
     }
 }