Skip to content

app-catalog: Show error feedback when helm install fails #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AshutoshSharma-pixel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

app-catalog: Show error feedback when helm install fails #786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 61 additions & 22 deletions app-catalog/src/components/charts/EditorDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,26 +129,49 @@ export function EditorDialog(props: {

function checkInstallStatus(releaseName: string) {
setTimeout(() => {
getActionStatus(releaseName, 'install').then((response: any) => {
if (response.status === 'processing') {
checkInstallStatus(releaseName);
} else if (!response.status || response.status !== 'success') {
getActionStatus(releaseName, 'install')
.then((response: any) => {
if (response.status === 'processing') {
checkInstallStatus(releaseName);
} else if (response.status !== 'success') {
enqueueSnackbar(
t('Error installing release {{ releaseName }}: {{ message }}', {
releaseName,
message: response.message || t('unknown error'),
}),
{
variant: 'error',
autoHideDuration: 5000,
}
);
handleEditor(false);
setInstallLoading(false);
} else {
enqueueSnackbar(
t('Release {{ releaseName }} installed successfully', { releaseName }),
{
variant: 'success',
autoHideDuration: 5000,
}
);
handleEditor(false);
setInstallLoading(false);
}
})
.catch((err: Error) => {
enqueueSnackbar(
t('Error creating release {{ message }}', { message: response.message }),
t('Error checking install status for {{ releaseName }}: {{ message }}', {
releaseName,
message: err?.message || t('unknown error'),
}),
{
variant: 'error',
autoHideDuration: 5000,
}
);
handleEditor(false);
setInstallLoading(false);
} else {
enqueueSnackbar(t('Release {{ releaseName }} created successfully', { releaseName }), {
variant: 'success',
});
handleEditor(false);
setInstallLoading(false);
}
});
});
}, 2000);
}

Expand Down Expand Up @@ -212,23 +235,39 @@ export function EditorDialog(props: {
t('Installation request for {{ releaseName }} accepted', { releaseName }),
{
variant: 'info',
autoHideDuration: 5000,
}
);
handleEditor(false);
checkInstallStatus(releaseName);
})
.catch(error => {
.catch((error: Error) => {
setInstallLoading(false);
handleEditor(false);
enqueueSnackbar(t('Error creating release request {{ error }}', { error }), {
variant: 'error',
});
enqueueSnackbar(
t('Error creating release {{ releaseName }}: {{ message }}', {
releaseName,
message: error?.message || String(error),
}),
{
variant: 'error',
autoHideDuration: 5000,
}
);
});
})
.catch(error => {
.catch((error: Error) => {
setInstallLoading(false);
handleEditor(false);
enqueueSnackbar(t('Error adding repository {{ error }}', { error }), {
variant: 'error',
});
enqueueSnackbar(
t('Error adding repository {{ repoName }}: {{ message }}', {
repoName,
message: error?.message || String(error),
}),
{
variant: 'error',
autoHideDuration: 5000,
}
);
});
}

Expand Down
Loading