app-catalog: Show error feedback when helm install fails#786
Open
AshutoshSharma-pixel wants to merge 1 commit into
Open
app-catalog: Show error feedback when helm install fails#786AshutoshSharma-pixel wants to merge 1 commit into
AshutoshSharma-pixel wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the app-catalog chart installation flow by ensuring Helm install failures (including status-polling network errors) surface clear UI feedback instead of leaving the dialog/loading state stuck or closing without explanation.
Changes:
- Adds error handling to the
getActionStatuspolling loop and shows a detailed error snackbar when status checks fail. - Ensures
installLoadingis cleared on install request failures and on install status failure/success, preventing the install button from remaining stuck. - Prevents premature dialog closure by keeping the dialog open until the install status polling completes, and standardizes snackbar auto-hide duration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .then((response: any) => { | ||
| if (response.status === 'processing') { | ||
| checkInstallStatus(releaseName); | ||
| } else if (response.status === 'failed' || response.status !== 'success') { |
Signed-off-by: Ashutosh Sharma <itsashutosh769@gmail.com>
AshutoshSharma-pixel
force-pushed
the
fix/app-catalog-install-error
branch
from
8efe781 to
c626f92
Compare
Contributor
Author
|
Simplified the condition to response.status !== 'success' as suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225
When a helm chart installation failed, the UI gave no feedback - the dialog would silently stay in a loading state or close without any error message.
Root causes fixed:
checkInstallStatus had no .catch() on the getActionStatus polling call - network errors were silently swallowed.
Both .catch() blocks in installAndCreateReleaseHandler called handleEditor(false) but never called setInstallLoading(false) leaving the install button stuck in "Installing..." indefinitely after failure.
Dialog was being closed prematurely before the status polling completed.
Error snackbars now include the specific error message and autoHideDuration: 5000