-
-
Notifications
You must be signed in to change notification settings - Fork 206
Add message option #2887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolocastro89
wants to merge
10
commits into
graphql-hive:master
Choose a base branch
from
nicolocastro89:AddMessageOption
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add message option #2887
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a9dda62
Add optional inputs for messages
nicolo-castro-hudl c2f574f
use input for title message
nicolo-castro-hudl f722fa8
add test for success and failure message
nicolo-castro-hudl dc8a6b9
force run
nicolo-castro-hudl c1e1231
ensure default message
nicolo-castro-hudl 1c15fe4
validate title
nicolo-castro-hudl b37a950
put new inputs at teh bottom
nicolo-castro-hudl 6acc55a
update documentation
nicolo-castro-hudl e44768e
aligning default values to the lable approach
nicolo-castro-hudl b0824bc
Update website/src/pages/docs/products/action.mdx
nicolocastro89 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than allow custom titles, should we instead mention this
approveLabeland similarly a failure label within the success/failure messages?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is also an option. I imagined not everyone has the same requirements regarding the message. Just like nobody required the labels in the message up until now there might be other needs; maybe someone wants to include a link to how the organisation handles breaking changes. This results in a non breaking change with added flexibility. Similarly to how the labels themselves are inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely a possible approach would be to allow parameters in the response ( for example writing
If these changes are expected you can used {approvedLabels} to bypass the checkbut that seemed overkill.