-
-
Notifications
You must be signed in to change notification settings - Fork 206
Add message option #2887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add message option #2887
Conversation
Co-authored-by: maxmelamed <[email protected]>
|
Updated the docs copy-paste typo |
jdolle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
I'd like to understand why this approach is preferred over including the labels at the end of the success/error messages. As is, I don't see how it resolves the issue.
| const useAnnotations = castToBoolean(core.getInput('annotations')); | ||
| const failOnBreaking = castToBoolean(core.getInput('fail-on-breaking')); | ||
| const endpoint: string = core.getInput('endpoint'); | ||
| const approveLabel: string = core.getInput('approve-label') || 'approved-breaking-change'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than allow custom titles, should we instead mention this approveLabel and similarly a failure label within the success/failure messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is also an option. I imagined not everyone has the same requirements regarding the message. Just like nobody required the labels in the message up until now there might be other needs; maybe someone wants to include a link to how the organisation handles breaking changes. This results in a non breaking change with added flexibility. Similarly to how the labels themselves are inputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely a possible approach would be to allow parameters in the response ( for example writing If these changes are expected you can used {approvedLabels} to bypass the check but that seemed overkill.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.
Description
My attempt to address this issue. This PR adds optional inputs to the github action which allows users to specify a success and failure message to post in place of the default one.
The issue mentioned having the label in the message, this makes it a bit more flexible by allowing the label and the message to be added.
Fixes # (issue)
#2656
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Test Environment:
@graphql-inspector/...:Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...