Skip to content

fix: lower chained secret Chebyshev evaluations natively #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexanderViand wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Open

fix: lower chained secret Chebyshev evaluations natively #3352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Transforms/LowerPolynomialEval/Patterns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ LogicalResult LowerViaPatersonStockmeyerChebyshev::matchAndRewrite(

LogicalResult LowerToKernelEvalChebyshev::matchAndRewrite(
EvalOp op, PatternRewriter& rewriter) const {
if (!mlir::heir::isSecret(op.getValue(), &solver)) {
return rewriter.notifyMatchFailure(op, "operand is not secret");
if (!mlir::heir::isSecret(op.getResult(), &solver)) {
return rewriter.notifyMatchFailure(op, "result is not secret");
}
auto attr = dyn_cast<polynomial::TypedChebyshevPolynomialAttr>(
op.getPolynomialAttr());
Expand Down
4 changes: 2 additions & 2 deletions tests/Examples/lattigo/ckks/relu_composite/relu_composite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
)

func TestReluComposite(t *testing.T) {
evaluator, params, ecd, enc, dec := Relu_composite__configure()
bootstrapEvaluator, evaluator, params, ecd, enc, dec := Relu_composite__configure()

const n = 16
arg0 := make([]float32, n)
Expand All @@ -23,7 +23,7 @@ func TestReluComposite(t *testing.T) {
ct0 := Relu_composite__encrypt__arg0(evaluator, params, ecd, enc, arg0)

start := time.Now()
resultCt := Relu_composite(evaluator, params, ecd, ct0)
resultCt := Relu_composite(bootstrapEvaluator, evaluator, params, ecd, ct0)
t.Logf("composite-sign ReLU took %s", time.Since(start))

result := Relu_composite__decrypt__result0(evaluator, params, ecd, dec, resultCt)
Expand Down
15 changes: 15 additions & 0 deletions tests/Transforms/lower_polynomial_eval/conditional_lower.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,21 @@ module attributes {
return %0 : !secret.secret<f64>
}

// CHECK: @test_secret_kernel_chain
func.func @test_secret_kernel_chain(%x: !secret.secret<f64>) -> !secret.secret<f64> {
// CHECK: %[[EVAL_0:.*]] = kernel.eval_chebyshev
// CHECK: %[[EVAL_1:.*]] = kernel.eval_chebyshev %[[EVAL_0]]
// CHECK: kernel.eval_chebyshev %[[EVAL_1]]
%0 = secret.generic(%x : !secret.secret<f64>) {
^body(%x_val: f64):
%1 = polynomial.eval #polynomial.typed_chebyshev_polynomial<[1.0, 2.0]> : !polynomial.polynomial<ring=<coefficientType=f64>>, %x_val {domain_lower = -1.0 : f64, domain_upper = 1.0 : f64} : f64
%2 = polynomial.eval #polynomial.typed_chebyshev_polynomial<[1.0, 2.0]> : !polynomial.polynomial<ring=<coefficientType=f64>>, %1 {domain_lower = -1.0 : f64, domain_upper = 1.0 : f64} : f64
%3 = polynomial.eval #polynomial.typed_chebyshev_polynomial<[1.0, 2.0]> : !polynomial.polynomial<ring=<coefficientType=f64>>, %2 {domain_lower = -1.0 : f64, domain_upper = 1.0 : f64} : f64
secret.yield %3 : f64
} -> (!secret.secret<f64>)
return %0 : !secret.secret<f64>
}

// CHECK: @test_public_kernel
func.func @test_public_kernel(%x: f64) -> f64 {
// CHECK-NOT: kernel.eval_chebyshev
Expand Down
Loading