fix: lower chained secret Chebyshev evaluations natively - #3352
Open
AlexanderViand wants to merge 1 commit into
Open
fix: lower chained secret Chebyshev evaluations natively#3352AlexanderViand wants to merge 1 commit into
AlexanderViand wants to merge 1 commit into
Conversation
AlexanderViand
force-pushed
the
alex/fix-chebyshev-kernel-lowering
branch
from
August 23, 2026 22:01
7d2d908 to
ffd79eb
Compare
SecretnessAnalysis runs before walk-based rewriting. Replacing an earlier eval creates a new operand with no lattice entry, while each later eval result remains analyzed. Query the result so chained secret evaluations consistently use native lowering.
AlexanderViand
force-pushed
the
alex/fix-chebyshev-kernel-lowering
branch
from
August 24, 2026 05:02
ffd79eb to
a64b9f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a situation like poly.eval(poly.eval(x)) which occurs, e.g., in composite ReLU lowerings, only the inner one would be lowered to kernel.chebyshev, the second one would incorrectly be detected to be non-secret:
Replacing the inner eval creates a new operand with no lattice entry for the outer eval, so we need to query on the result rather than the operand.