Draft: Quickfix extra quotes by removing them from LSP response

src/lsp/GDScriptLanguageClient.ts

@@ -14,6 +14,7 @@ import {
 import { globals } from "../extension";
 import { createLogger, get_configuration, get_project_dir } from "../utils";
 import { MessageIO } from "./MessageIO";
+import { LSPMiddleware } from "./LSPMiddleware";
 
 const log = createLogger("lsp.client", { output: "Godot LSP" });
 
@@ -116,6 +117,7 @@ export default class GDScriptLanguageClient extends LanguageClient {
 				{ scheme: "file", language: "gdscript" },
 				{ scheme: "untitled", language: "gdscript" },
 			],
+			middleware: new LSPMiddleware()
 		};
 
 		super("GDScriptLanguageClient", serverOptions, clientOptions);

src/lsp/LSPMiddleware.ts

@@ -0,0 +1,75 @@
+
+
+import * as vscode from "vscode";
+import { Middleware, ProvideCompletionItemsSignature } from "vscode-languageclient";
+
+type QuotesPresense = {
+    before: boolean;
+    after: boolean;
+    quoteChar: string | null;
+}
+
+export class LSPMiddleware implements Middleware {
+    constructor() {}
+
+    async provideCompletionItem(
+        document: vscode.TextDocument, 
+        position: vscode.Position, 
+        context: vscode.CompletionContext, 
+        token: vscode.CancellationToken, 
+        next: ProvideCompletionItemsSignature
+    ): Promise<vscode.CompletionItem[] | vscode.CompletionList> {
+        // TODO: this is quickfix, should be changed on LSP side later
+        const quotesPresense = this.areQuotesPresent(document, position);
+
+        if (quotesPresense.quoteChar !== null) {
+            const result = await next(document, position, context, token);
+            if (Array.isArray(result)) {
+                return result.map((item) => {
+                    let textWithModifiedQuotes = item.insertText.toString().replace(/(^")|("$)/g, "");
+
+                    textWithModifiedQuotes = 
+                        (quotesPresense.before ? "" : quotesPresense.quoteChar) + 
+                        textWithModifiedQuotes +
+                        (quotesPresense.after ? "" : quotesPresense.quoteChar);
+
+                    return {
+                        ...item,
+                        insertText: textWithModifiedQuotes
+                    };
+                });
+            }
+        }
+        return next(document, position, context, token);
+    }
+
+    private areQuotesPresent(document: vscode.TextDocument, position: vscode.Position): QuotesPresense {
+        const line = document.lineAt(position.line).text;
+
+        const charBefore = position.character > 0 ? line[position.character - 1] : "";
+        const charAfter =
+            position.character < line.length ? line[position.character] : "";
+
+        if (charBefore === "\"" || charAfter === "\"") {
+            return {
+                before: charBefore === "\"",
+                after: charAfter === "\"",
+                quoteChar: "\""
+            };
+        }
+
+        if (charBefore === "\'" || charAfter === "\'") {
+            return {
+                before: charBefore === "\'",
+                after: charAfter === "\'",
+                quoteChar: "\'"
+            };
+        }
+
+        return {
+            before: false,
+            after: false,
+            quoteChar: null
+        };
+    }
+}