Draft: Quickfix extra quotes by removing them from LSP response #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-loginov
changed the title
Collaborator
|
I WAS going to tell you I've tried this by rewriting the incoming messages and it was so unreliable that I'm not interested in a client side bandaid fix anymore, but I've never seen this middleware mechanism. I'm very interested to test this out. |
Author
|
Yeah, I'm still testing it right now, and you're right, it's all junky and there is more stuff to make it work as intended. In current state only works for simple cases. |
Collaborator
|
No problem. We can also slap a setting in front of this and mark it experimental. I have some other dirty hacks that I think would be cleaner if I move them to this middleware layer, so this PR won't be wasted even if the quote thing doesn't work out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #885