Skip to content

Rename shadowed loop variables in plot utility and writers #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JanFSchulte wants to merge 1 commit into from
Closed

Rename shadowed loop variables in plot utility and writers #1602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hls4ml/utils/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def model_to_dot(
layers = model.get_layers()

# Create graph nodes.
for i, layer in enumerate(layers):
for layer in layers:
# layer_id = str(id(layer))
layer_id = str(layer.index)

Expand Down Expand Up @@ -112,8 +112,8 @@ def format_shape(shape):
if class_name != 'Input':
if len(layer.inputs) > 1:
input_shapes = []
for i in layer.inputs:
input_layer = layer.get_input_variable(i)
for input_name in layer.inputs:
input_layer = layer.get_input_variable(input_name)
if input_layer is not None:
input_shapes.append(input_layer.shape)
else:
Expand Down
4 changes: 2 additions & 2 deletions hls4ml/writer/catapult_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ def write_project_cpp(self, model):
newline += ' ' + func[0] + ' // ' + layer.name + '\n'
else:
newline += ' // ' + layer.name + '\n'
for line in func:
newline += ' ' + line + '\n'
for func_line in func:
newline += ' ' + func_line + '\n'
if model.config.trace_output and layer.get_attr('trace', False):
newline += '#ifndef __SYNTHESIS__\n'
for var in vars:
Expand Down
4 changes: 2 additions & 2 deletions hls4ml/writer/coyote_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ def write_project_cpp(self, model):
newline += ' ' + func[0] + ' // ' + layer.name + '\n'
else:
newline += ' // ' + layer.name + '\n'
for line in func:
newline += ' ' + line + '\n'
for func_line in func:
newline += ' ' + func_line + '\n'
if model.config.trace_output and layer.get_attr('trace', False):
vars = layer.get_variables()
newline += '#ifndef __SYNTHESIS__\n'
Expand Down
4 changes: 2 additions & 2 deletions hls4ml/writer/libero_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,8 @@ def write_project_cpp(self, model):
newline += ' ' + func[0] + ' // ' + layer.name + '\n'
else:
newline += ' // ' + layer.name + '\n'
for line in func:
newline += ' ' + line + '\n'
for func_line in func:
newline += ' ' + func_line + '\n'
if model.config.trace_output and layer.get_attr('trace', False):
newline += '#ifndef __SYNTHESIS__\n'
for var in vars:
Expand Down
4 changes: 2 additions & 2 deletions hls4ml/writer/vivado_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@ def write_project_cpp(self, model):
newline += ' ' + func[0] + ' // ' + layer.name + '\n'
else:
newline += ' // ' + layer.name + '\n'
for line in func:
newline += ' ' + line + '\n'
for func_line in func:
newline += ' ' + func_line + '\n'
if model.config.trace_output and layer.get_attr('trace', False):
vars = layer.get_variables()
newline += '#ifndef __SYNTHESIS__\n'
Expand Down
Loading