Repository navigation
Rename shadowed loop variables in plot utility and writers - #1602
Closed
JanFSchulte wants to merge 1 commit into
Closed
JanFSchulte wants to merge 1 commit into
JanFSchulte wants to merge 1 commit into
Conversation
The inner loops over layer functions in the Catapult, Coyote, Libero and Vivado writers reused the name of the outer template line variable. Rename it to func_line, and likewise rename the shadowing loop variable in model_to_dot.
Contributor
Author
|
Ah, this is included in #1599 already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The inner loops over layer functions in the Catapult, Coyote, Libero and Vivado writers reused the name of the outer template line variable. Rename it to func_line, and likewise rename the shadowing loop variable in model_to_dot.
Fixes the newly appearing flake8 errors B045.
Type of change
io_type, Strategy, or config attributeAffected areas
Backends:
hls4ml.model)Frontends:
Components:
hls4ml/templates/Configurations affected and exercised
io_typeNew configuration axis introduced by this PR (if any):
Impact on generated HLS
Numerical behaviour:
Tests
pre-commit passes now.
Breaking changes and migration
AI assistance disclosure
Tool(s) and model(s): Claude Opus 5.5
Where it was used: Verified that the pre-commit findings weren't spurious and then fixed them
If anything other than None is ticked, confirm all of the following:
it. I have read and understood every line and can explain and defend it
in review.
no invented APIs, config keys, pragmas or citations.
actually performed, not from agent output.
my knowledge it does not reproduce third-party code that would conflict
with it.
Checklist
Required:
pre-commiton the files I edited.test/pytestcovering this change (a bug fix shouldadd a test that fails on
mainand passes here).commented-out blocks or unrelated changes.
If applicable:
docs/updated.Release note