Skip to content

Add variables for house inputs #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glennj merged 2 commits into from
Jun 10, 2025
Merged

Add variables for house inputs #623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20a2684
Add variables for `house` inputs
BNAndras Jun 9, 2025
def036e
Reformat line to 120 characters
BNAndras Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 42 additions & 14 deletions exercises/practice/house/test/house_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,41 +6,52 @@ void main() {

group('House', () {
test('verse one - the house that Jack built', () {
final startVerse = 1;
final endVerse = 1;
final result = house.recite(startVerse, endVerse);
final expected = 'This is the house that Jack built.';
final result = house.recite(1, 1);
expect(result, equals(expected));
}, skip: false);

test('verse two - the malt that lay', () {
final startVerse = 2;
final endVerse = 2;
final result = house.recite(startVerse, endVerse);
final expected = 'This is the malt that lay in the house that Jack built.';
final result = house.recite(2, 2);
expect(result, equals(expected));
}, skip: true);

test('verse three - the rat that ate', () {
final startVerse = 3;
final endVerse = 3;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the rat',
'that ate the malt',
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(3, 3);
expect(result, equals(expected));
}, skip: true);

test('verse four - the cat that killed', () {
final startVerse = 4;
final endVerse = 4;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the cat',
'that killed the rat',
'that ate the malt',
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(4, 4);
expect(result, equals(expected));
}, skip: true);

test('verse five - the dog that worried', () {
final startVerse = 5;
final endVerse = 5;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the dog',
'that worried the cat',
Expand All @@ -49,11 +60,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(5, 5);
expect(result, equals(expected));
}, skip: true);

test('verse six - the cow with the crumpled horn', () {
final startVerse = 6;
final endVerse = 6;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the cow with the crumpled horn',
'that tossed the dog',
Expand All @@ -63,11 +76,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(6, 6);
expect(result, equals(expected));
}, skip: true);

test('verse seven - the maiden all forlorn', () {
final startVerse = 7;
final endVerse = 7;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the maiden all forlorn',
'that milked the cow with the crumpled horn',
Expand All @@ -78,11 +93,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(7, 7);
expect(result, equals(expected));
}, skip: true);

test('verse eight - the man all tattered and torn', () {
final startVerse = 8;
final endVerse = 8;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the man all tattered and torn',
'that kissed the maiden all forlorn',
Expand All @@ -94,11 +111,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(8, 8);
expect(result, equals(expected));
}, skip: true);

test('verse nine - the priest all shaven and shorn', () {
final startVerse = 9;
final endVerse = 9;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the priest all shaven and shorn',
'that married the man all tattered and torn',
Expand All @@ -111,11 +130,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(9, 9);
expect(result, equals(expected));
}, skip: true);

test('verse ten - the rooster that crowed in the morn', () {
final startVerse = 10;
final endVerse = 10;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the rooster that crowed in the morn',
'that woke the priest all shaven and shorn',
Expand All @@ -129,11 +150,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(10, 10);
expect(result, equals(expected));
}, skip: true);

test('verse eleven - the farmer sowing his corn', () {
final startVerse = 11;
final endVerse = 11;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the farmer sowing his corn',
'that kept the rooster that crowed in the morn',
Expand All @@ -148,11 +171,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(11, 11);
expect(result, equals(expected));
}, skip: true);

test('verse 12 - the horse and the hound and the horn', () {
final startVerse = 12;
final endVerse = 12;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the horse and the hound and the horn',
'that belonged to the farmer sowing his corn',
Expand All @@ -168,11 +193,13 @@ void main() {
'that lay in the house',
'that Jack built.',
].join(' ');
final result = house.recite(12, 12);
expect(result, equals(expected));
}, skip: true);

test('multiple verses', () {
final startVerse = 4;
final endVerse = 8;
final result = house.recite(startVerse, endVerse);
final expected = [
[
'This is the cat that killed the rat',
Expand Down Expand Up @@ -206,11 +233,13 @@ void main() {
'that lay in the house that Jack built.',
].join(' '),
].join('\n');
final result = house.recite(4, 8);
expect(result, equals(expected));
}, skip: true);

test('full rhyme', () {
final startVerse = 1;
final endVerse = 12;
final result = house.recite(startVerse, endVerse);
final expected = [
'This is the house that Jack built.',
'This is the malt that lay in the house that Jack built.',
Expand Down Expand Up @@ -292,7 +321,6 @@ void main() {
'that lay in the house that Jack built.',
].join(' '),
].join('\n');
final result = house.recite(1, 12);
expect(result, equals(expected));
}, skip: true);
});
Expand Down