Skip to content

Add variables for house inputs#623

Merged
glennj merged 2 commits into
exercism:mainfrom
BNAndras:clarify-house-tests
Jun 10, 2025
Merged

Add variables for house inputs#623
glennj merged 2 commits into
exercism:mainfrom
BNAndras:clarify-house-tests

Conversation

@BNAndras

@BNAndras BNAndras commented Jun 9, 2025

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@glennj

glennj commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Not sure why that check is failing: dart run bin/check_formatting.dart

@BNAndras

Copy link
Copy Markdown
Member Author

Yeah, I have sporadic fights with the formatter because the CI wants line lengths of 120, but the default for dart format is 80. The formatter complains if a line is formatted to be shorter when it originally would have been under the line length threshold. I don't recall running dart format so maybe a plugin ran it for me and I didn't catch that it happened.

@glennj glennj merged commit a6aca07 into exercism:main Jun 10, 2025
4 checks passed
@BNAndras BNAndras deleted the clarify-house-tests branch June 10, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants